Include params in response, ensure accidental local hosting deployments are built properly

This commit is contained in:
Xevion
2022-05-25 19:20:17 -05:00
parent f092708259
commit 48a6b3bbfc
2 changed files with 8 additions and 5 deletions

View File

@@ -1,6 +1,9 @@
{ {
"hosting": { "hosting": {
"public": "build", "public": "build",
"predeploy": [
"yarn run build"
],
"ignore": [ "ignore": [
"firebase.json", "firebase.json",
"**/.*", "**/.*",

View File

@@ -11,7 +11,7 @@ let quoteData: any = null;
export const surrounding = functions.https.onRequest( export const surrounding = functions.https.onRequest(
async (request, response) => { async (request, response) => {
const params = {season: -1, episode: -1, scene: -1, quote: -1}; const params = {season: -1, episode: -1, scene: -1, quote: -1, radius: -1};
try { try {
params.season = Number(request.query.season); params.season = Number(request.query.season);
params.episode = Number(request.query.episode); params.episode = Number(request.query.episode);
@@ -26,7 +26,7 @@ export const surrounding = functions.https.onRequest(
const minRadius = 1; const minRadius = 1;
const maxRadius = 5; const maxRadius = 5;
const defaultRadius = 2; const defaultRadius = 2;
const radius = Math.min(Math.max(Number(request.query.radius) || defaultRadius, minRadius), maxRadius); params.radius = Math.min(Math.max(Number(request.query.radius) || defaultRadius, minRadius), maxRadius);
// Check that all query parameters were given correctly. // Check that all query parameters were given correctly.
for (const [k, v] of Object.entries(params)) { for (const [k, v] of Object.entries(params)) {
@@ -46,8 +46,8 @@ export const surrounding = functions.https.onRequest(
const surrounding = {center: sceneData[params.quote - 1], above: [], below: []}; const surrounding = {center: sceneData[params.quote - 1], above: [], below: []};
const quoteIndex = params.quote - 1; const quoteIndex = params.quote - 1;
if (radius > 0) { if (params.radius > 0) {
for (let i = 0; i < radius; i++) { for (let i = 0; i < params.radius; i++) {
const topIndex = quoteIndex - (i + 1); const topIndex = quoteIndex - (i + 1);
const bottomIndex = quoteIndex + (i + 1); const bottomIndex = quoteIndex + (i + 1);
@@ -61,5 +61,5 @@ export const surrounding = functions.https.onRequest(
} }
} }
response.send(surrounding).end(); response.send({...surrounding, params}).end();
}); });