Add notes on future normalization checks, improve logging minorly

This commit is contained in:
Xevion
2022-05-09 16:26:25 -05:00
parent d56d77ace1
commit 21c0d8088f

View File

@@ -518,16 +518,19 @@ def check(verbose: bool) -> None:
speaker_name: str = character.find('RawText').text speaker_name: str = character.find('RawText').text
if annotate_state is None: if annotate_state is None:
logger.warning(f'Null annotation on `{speaker_name}`') logger.warning(f'Missing annotation on `{speaker_name}`')
elif annotate_state == "true": elif annotate_state == "true":
if character.find('AnnotatedText') is None: if character.find('AnnotatedText') is None:
logger.warning(f'Missing AnnotatedText on `{speaker_name}`') logger.warning(f'Missing AnnotatedText on `{speaker_name}`')
elif annotate_state == "false": elif annotate_state == "false":
if character.find('AnnotatedText') is not None: if character.find('AnnotatedText') is not None:
logger.warning(f'False annotatation on `{speaker_name}`') logger.warning(f'False annotation on `{speaker_name}`')
else: else:
logger.warning(f"Unexpected annotation state `{annotate_state}` on `{speaker_name}`") logger.warning(f"Unexpected annotation state `{annotate_state}` on `{speaker_name}`")
# TODO: Check for values in meta.json that are null
# TODO: Check for values in meta.json that are not referenced anywhere in identifiers.xml
if __name__ == '__main__': if __name__ == '__main__':
cli() cli()