From c3fe5691c61dcd322797636505e6892ecdb1ba19 Mon Sep 17 00:00:00 2001
From: Xevion <xevion@xevion.dev>
Date: Thu, 9 May 2024 02:11:46 -0500
Subject: [PATCH] fix: format zod errors better, format newlines correctly in
 error card

---
 src/components/common/ErrorCard.tsx |  2 +-
 src/hooks/useLookup.tsx             | 51 ++++++++++++++++++++---------
 2 files changed, 37 insertions(+), 16 deletions(-)

diff --git a/src/components/common/ErrorCard.tsx b/src/components/common/ErrorCard.tsx
index 891bc6b..2d8d7ba 100644
--- a/src/components/common/ErrorCard.tsx
+++ b/src/components/common/ErrorCard.tsx
@@ -21,7 +21,7 @@ const ErrorCard: FunctionComponent<ErrorCardProps> = ({
         <div className="ml-3 text-sm text-red-300">
           <h3 className="font-medium text-red-200">{title}</h3>
           {description != undefined ? (
-            <div className="mt-2">{description}</div>
+            <div className="mt-2 whitespace-pre-wrap" >{description}</div>
           ) : null}
           <div className="mt-2">
             {issues != undefined ? (
diff --git a/src/hooks/useLookup.tsx b/src/hooks/useLookup.tsx
index 992d86e..3620f79 100644
--- a/src/hooks/useLookup.tsx
+++ b/src/hooks/useLookup.tsx
@@ -134,17 +134,37 @@ const useLookup = (warningHandler?: WarningHandler) => {
   async function getAndParse<T>(
     url: string,
     schema: ZodSchema
-  ): Promise<Maybe<T>> {
+  ): Promise<Result<T, Error>> {
     const response = await fetch(url);
+
     if (response.status == 200) {
-      const safeValue = schema.safeParse(await response.json());
-      if (safeValue.success) return Maybe.just(safeValue.data);
-      else {
-        console.error(safeValue.error);
-        return Maybe.nothing();
+      const result = schema.safeParse(await response.json());
+
+      if (result.success === false) {
+        // flatten the errors to make them more readable and simple
+        const flatErrors = result.error.flatten(function (issue) {
+          const path = issue.path.map((value => value.toString())).join('.');
+          return `${path}: ${issue.message}`;
+        });
+
+        console.log(flatErrors);
+
+        // combine them all, wrap them in a new error, and return it
+        return Result.err(new Error([
+          "Could not parse the response from the registry.",
+          ...flatErrors.formErrors,
+          ...Object.values(flatErrors.fieldErrors).flat(),
+        ].join('\n')));
       }
+
+      return Result.ok(result.data);
     }
-    return Maybe.nothing();
+
+    return Result.err(
+      new Error(
+        `The registry did not return an OK status code: ${response.status}.`
+      )
+    );
   }
 
   async function submitInternal(): Promise<Result<ParsedGeneric, Error>> {
@@ -169,16 +189,16 @@ const useLookup = (warningHandler?: WarningHandler) => {
         await loadBootstrap("ip4");
         const url = getRegistryURL(targetType.value, target);
         const result = await getAndParse<IpNetwork>(url, IpNetworkSchema);
-        if (result.isNothing)
-          return Result.err(new Error("No data was returned from the lookup."));
+        if (result.isErr)
+          return Result.err(result.error);
         return Result.ok(result.value);
       }
       case "ip6": {
         await loadBootstrap("ip6");
         const url = getRegistryURL(targetType.value, target);
         const result = await getAndParse<IpNetwork>(url, IpNetworkSchema);
-        if (result.isNothing)
-          return Result.err(new Error("No data was returned from the lookup."));
+        if (result.isErr)
+          return Result.err(result.error);
         return Result.ok(result.value);
       }
       case "domain": {
@@ -196,8 +216,9 @@ const useLookup = (warningHandler?: WarningHandler) => {
           );
         }
         const result = await getAndParse<Domain>(url, DomainSchema);
-        if (result.isNothing)
-          return Result.err(new Error("No data was returned from the lookup."));
+        if (result.isErr)
+          return Result.err(result.error);
+
         return Result.ok(result.value);
       }
       case "autnum": {
@@ -207,8 +228,8 @@ const useLookup = (warningHandler?: WarningHandler) => {
           url,
           AutonomousNumberSchema
         );
-        if (result.isNothing)
-          return Result.err(new Error("No data was returned from the lookup."));
+        if (result.isErr)
+          return Result.err(result.error);
         return Result.ok(result.value);
       }
       case "url":