Bugfixes, finished filter rework

lib/features/documents/view/widgets/selection/documents_page_app_bar.dart

@@ -1,17 +1,21 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:paperless_api/paperless_api.dart';
+import 'package:paperless_mobile/core/widgets/offline_banner.dart';
 import 'package:paperless_mobile/features/documents/bloc/documents_cubit.dart';
 import 'package:paperless_mobile/features/documents/view/widgets/selection/bulk_delete_confirmation_dialog.dart';
 import 'package:paperless_mobile/features/saved_view/view/saved_view_selection_widget.dart';
 import 'package:paperless_mobile/generated/l10n.dart';
 import 'package:paperless_mobile/util.dart';
+import 'package:paperless_mobile/extensions/flutter_extensions.dart';
 
 class DocumentsPageAppBar extends StatefulWidget with PreferredSizeWidget {
   final List<Widget> actions;
+  final bool isOffline;
 
   const DocumentsPageAppBar({
     super.key,
+    required this.isOffline,
     this.actions = const [],
   });
   @override
@@ -21,19 +25,27 @@ class DocumentsPageAppBar extends StatefulWidget with PreferredSizeWidget {
 }
 
 class _DocumentsPageAppBarState extends State<DocumentsPageAppBar> {
-  static const _flexibleAreaHeight = kToolbarHeight + 48.0;
   @override
   Widget build(BuildContext context) {
+    const savedViewWidgetHeight = 48.0;
+    final flexibleAreaHeight = kToolbarHeight -
+        16 +
+        savedViewWidgetHeight +
+        (widget.isOffline ? 24 : 0);
     return BlocBuilder<DocumentsCubit, DocumentsState>(
       builder: (context, documentsState) {
         final hasSelection = documentsState.selection.isNotEmpty;
         if (hasSelection) {
           return SliverAppBar(
-            expandedHeight: kToolbarHeight + _flexibleAreaHeight,
+            expandedHeight: kToolbarHeight + flexibleAreaHeight,
             snap: true,
             floating: true,
             pinned: true,
-            flexibleSpace: _buildFlexibleArea(false, documentsState.filter),
+            flexibleSpace: _buildFlexibleArea(
+              false,
+              documentsState.filter,
+              savedViewWidgetHeight,
+            ),
             leading: IconButton(
               icon: const Icon(Icons.close),
               onPressed: () =>
@@ -50,13 +62,14 @@ class _DocumentsPageAppBarState extends State<DocumentsPageAppBar> {
           );
         } else {
           return SliverAppBar(
-            expandedHeight: kToolbarHeight + _flexibleAreaHeight,
+            expandedHeight: kToolbarHeight + flexibleAreaHeight,
             snap: true,
             floating: true,
             pinned: true,
             flexibleSpace: _buildFlexibleArea(
               true,
               documentsState.filter,
+              savedViewWidgetHeight,
             ),
             title: Text(
               '${S.of(context).documentsPageTitle} (${_formatDocumentCount(documentsState.count)})',
@@ -70,30 +83,31 @@ class _DocumentsPageAppBarState extends State<DocumentsPageAppBar> {
     );
   }
 
-  Widget _buildFlexibleArea(bool enabled, DocumentFilter filter) {
+  Widget _buildFlexibleArea(
+    bool enabled,
+    DocumentFilter filter,
+    double savedViewHeight,
+  ) {
     return FlexibleSpaceBar(
-      background: Padding(
-        padding: const EdgeInsets.all(8.0),
-        child: Column(
-          mainAxisAlignment: MainAxisAlignment.end,
-          children: [
-            SavedViewSelectionWidget(
-              height: 48,
-              enabled: enabled,
-              currentFilter: filter,
-            ),
-          ],
-        ),
+      background: Column(
+        mainAxisAlignment: MainAxisAlignment.end,
+        children: [
+          if (widget.isOffline) const OfflineBanner(),
+          SavedViewSelectionWidget(
+            height: savedViewHeight,
+            enabled: enabled,
+            currentFilter: filter,
+          ).paddedSymmetrically(horizontal: 8.0),
+        ],
       ),
     );
   }
 
   void _onDelete(BuildContext context, DocumentsState documentsState) async {
     final shouldDelete = await showDialog<bool>(
-          context: context,
-          builder: (context) =>
-              BulkDeleteConfirmationDialog(state: documentsState),
-        ) ??
+            context: context,
+            builder: (context) =>
+                BulkDeleteConfirmationDialog(state: documentsState)) ??
         false;
     if (shouldDelete) {
       try {