feat: Fix hive errors, change provider hierarchy for blocs, translate strings

lib/features/document_details/cubit/document_details_cubit.dart

@@ -54,12 +54,16 @@ class DocumentDetailsCubit extends Cubit<DocumentDetailsState> {
 
   Future<void> loadSuggestions() async {
     final suggestions = await _api.findSuggestions(state.document);
-    emit(state.copyWith(suggestions: suggestions));
+    if (!isClosed) {
+      emit(state.copyWith(suggestions: suggestions));
+    }
   }
 
   Future<void> loadMetaData() async {
     final metaData = await _api.getMetaData(state.document);
-    emit(state.copyWith(metaData: metaData));
+    if (!isClosed) {
+      emit(state.copyWith(metaData: metaData));
+    }
   }
 
   Future<void> loadFullContent() async {
@@ -85,8 +89,8 @@ class DocumentDetailsCubit extends Cubit<DocumentDetailsState> {
       _notifier.notifyUpdated(updatedDocument);
     } else {
       final int autoAsn = await _api.findNextAsn();
-      final updatedDocument = await _api
-          .update(document.copyWith(archiveSerialNumber: () => autoAsn));
+      final updatedDocument =
+          await _api.update(document.copyWith(archiveSerialNumber: () => autoAsn));
       _notifier.notifyUpdated(updatedDocument);
     }
   }
@@ -97,8 +101,7 @@ class DocumentDetailsCubit extends Cubit<DocumentDetailsState> {
     if (state.metaData == null) {
       await loadMetaData();
     }
-    final desc = FileDescription.fromPath(
-        state.metaData!.mediaFilename.replaceAll("/", " "));
+    final desc = FileDescription.fromPath(state.metaData!.mediaFilename.replaceAll("/", " "));
 
     final fileName = "${desc.filename}.pdf";
     final file = File("${cacheDir.path}/$fileName");
@@ -132,8 +135,7 @@ class DocumentDetailsCubit extends Cubit<DocumentDetailsState> {
       await FileService.downloadsDirectory,
     );
     final desc = FileDescription.fromPath(
-      state.metaData!.mediaFilename
-          .replaceAll("/", " "), // Flatten directory structure
+      state.metaData!.mediaFilename.replaceAll("/", " "), // Flatten directory structure
     );
     if (!File(filePath).existsSync()) {
       File(filePath).createSync();
@@ -198,8 +200,7 @@ class DocumentDetailsCubit extends Cubit<DocumentDetailsState> {
 
   String _buildDownloadFilePath(bool original, Directory dir) {
     final description = FileDescription.fromPath(
-      state.metaData!.mediaFilename
-          .replaceAll("/", " "), // Flatten directory structure
+      state.metaData!.mediaFilename.replaceAll("/", " "), // Flatten directory structure
     );
     final extension = original ? description.extension : 'pdf';
     return "${dir.path}/${description.filename}.$extension";

lib/features/document_details/view/pages/document_details_page.dart

@@ -60,36 +60,28 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
   Widget build(BuildContext context) {
     return WillPopScope(
       onWillPop: () async {
-        Navigator.of(context)
-            .pop(context.read<DocumentDetailsCubit>().state.document);
+        Navigator.of(context).pop(context.read<DocumentDetailsCubit>().state.document);
         return false;
       },
       child: DefaultTabController(
         length: 4,
         child: BlocListener<ConnectivityCubit, ConnectivityState>(
-          listenWhen: (previous, current) =>
-              !previous.isConnected && current.isConnected,
+          listenWhen: (previous, current) => !previous.isConnected && current.isConnected,
           listener: (context, state) {
             _loadMetaData();
             setState(() {});
           },
           child: Scaffold(
             extendBodyBehindAppBar: false,
-            floatingActionButtonLocation:
-                FloatingActionButtonLocation.endDocked,
+            floatingActionButtonLocation: FloatingActionButtonLocation.endDocked,
             floatingActionButton: widget.allowEdit ? _buildEditButton() : null,
             bottomNavigationBar: _buildBottomAppBar(),
             body: NestedScrollView(
               headerSliverBuilder: (context, innerBoxIsScrolled) => [
                 SliverOverlapAbsorber(
-                  handle:
-                      NestedScrollView.sliverOverlapAbsorberHandleFor(context),
+                  handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
                   sliver: SliverAppBar(
-                    title: Text(context
-                        .watch<DocumentDetailsCubit>()
-                        .state
-                        .document
-                        .title),
+                    title: Text(context.watch<DocumentDetailsCubit>().state.document.title),
                     leading: const BackButton(),
                     pinned: true,
                     forceElevated: innerBoxIsScrolled,
@@ -99,8 +91,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                       background: Stack(
                         alignment: Alignment.topCenter,
                         children: [
-                          BlocBuilder<DocumentDetailsCubit,
-                              DocumentDetailsState>(
+                          BlocBuilder<DocumentDetailsCubit, DocumentDetailsState>(
                             builder: (context, state) => Positioned.fill(
                               child: DocumentPreview(
                                 document: state.document,
@@ -137,9 +128,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                             child: Text(
                               S.of(context)!.overview,
                               style: TextStyle(
-                                color: Theme.of(context)
-                                    .colorScheme
-                                    .onPrimaryContainer,
+                                color: Theme.of(context).colorScheme.onPrimaryContainer,
                               ),
                             ),
                           ),
@@ -147,9 +136,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                             child: Text(
                               S.of(context)!.content,
                               style: TextStyle(
-                                color: Theme.of(context)
-                                    .colorScheme
-                                    .onPrimaryContainer,
+                                color: Theme.of(context).colorScheme.onPrimaryContainer,
                               ),
                             ),
                           ),
@@ -157,9 +144,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                             child: Text(
                               S.of(context)!.metaData,
                               style: TextStyle(
-                                color: Theme.of(context)
-                                    .colorScheme
-                                    .onPrimaryContainer,
+                                color: Theme.of(context).colorScheme.onPrimaryContainer,
                               ),
                             ),
                           ),
@@ -167,9 +152,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                             child: Text(
                               S.of(context)!.similarDocuments,
                               style: TextStyle(
-                                color: Theme.of(context)
-                                    .colorScheme
-                                    .onPrimaryContainer,
+                                color: Theme.of(context).colorScheme.onPrimaryContainer,
                               ),
                             ),
                           ),
@@ -198,8 +181,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                           CustomScrollView(
                             slivers: [
                               SliverOverlapInjector(
-                                handle: NestedScrollView
-                                    .sliverOverlapAbsorberHandleFor(context),
+                                handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
                               ),
                               DocumentOverviewWidget(
                                 document: state.document,
@@ -215,8 +197,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                           CustomScrollView(
                             slivers: [
                               SliverOverlapInjector(
-                                handle: NestedScrollView
-                                    .sliverOverlapAbsorberHandleFor(context),
+                                handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
                               ),
                               DocumentContentWidget(
                                 isFullContentLoaded: state.isFullContentLoaded,
@@ -229,8 +210,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                           CustomScrollView(
                             slivers: [
                               SliverOverlapInjector(
-                                handle: NestedScrollView
-                                    .sliverOverlapAbsorberHandleFor(context),
+                                handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
                               ),
                               DocumentMetaDataWidget(
                                 document: state.document,
@@ -242,8 +222,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                             controller: _pagingScrollController,
                             slivers: [
                               SliverOverlapInjector(
-                                handle: NestedScrollView
-                                    .sliverOverlapAbsorberHandleFor(context),
+                                handle: NestedScrollView.sliverOverlapAbsorberHandleFor(context),
                               ),
                               SimilarDocumentsView(
                                 pagingScrollController: _pagingScrollController,
@@ -301,9 +280,8 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                   IconButton(
                     tooltip: S.of(context)!.deleteDocumentTooltip,
                     icon: const Icon(Icons.delete),
-                    onPressed: widget.allowEdit && isConnected
-                        ? () => _onDelete(state.document)
-                        : null,
+                    onPressed:
+                        widget.allowEdit && isConnected ? () => _onDelete(state.document) : null,
                   ).paddedSymmetrically(horizontal: 4),
                   DocumentDownloadButton(
                     document: state.document,
@@ -313,8 +291,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
                   IconButton(
                     tooltip: S.of(context)!.previewTooltip,
                     icon: const Icon(Icons.visibility),
-                    onPressed:
-                        isConnected ? () => _onOpen(state.document) : null,
+                    onPressed: isConnected ? () => _onOpen(state.document) : null,
                   ).paddedOnly(right: 4.0),
                   IconButton(
                     tooltip: S.of(context)!.openInSystemViewer,
@@ -352,8 +329,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
               ),
             ],
             child: BlocListener<DocumentEditCubit, DocumentEditState>(
-              listenWhen: (previous, current) =>
-                  previous.document != current.document,
+              listenWhen: (previous, current) => previous.document != current.document,
               listener: (context, state) {
                 cubit.replace(state.document);
               },
@@ -373,8 +349,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
   }
 
   void _onOpenFileInSystemViewer() async {
-    final status =
-        await context.read<DocumentDetailsCubit>().openDocumentInSystemViewer();
+    final status = await context.read<DocumentDetailsCubit>().openDocumentInSystemViewer();
     if (status == ResultType.done) return;
     if (status == ResultType.noAppToOpen) {
       showGenericError(context, S.of(context)!.noAppToDisplayPDFFilesFound);
@@ -383,16 +358,14 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
       showGenericError(context, translateError(context, ErrorCode.unknown));
     }
     if (status == ResultType.permissionDenied) {
-      showGenericError(
-          context, S.of(context)!.couldNotOpenFilePermissionDenied);
+      showGenericError(context, S.of(context)!.couldNotOpenFilePermissionDenied);
     }
   }
 
   void _onDelete(DocumentModel document) async {
     final delete = await showDialog(
           context: context,
-          builder: (context) =>
-              DeleteDocumentConfirmationDialog(document: document),
+          builder: (context) => DeleteDocumentConfirmationDialog(document: document),
         ) ??
         false;
     if (delete) {
@@ -412,8 +385,7 @@ class _DocumentDetailsPageState extends State<DocumentDetailsPage> {
     Navigator.of(context).push(
       MaterialPageRoute(
         builder: (context) => DocumentView(
-          documentBytes:
-              context.read<PaperlessDocumentsApi>().getPreview(document.id),
+          documentBytes: context.read<PaperlessDocumentsApi>().getPreview(document.id),
         ),
       ),
     );