Cleaned up code, implemented message queue to notify subscribers of document updates.

lib/features/inbox/view/pages/inbox_page.dart

@@ -31,7 +31,7 @@ class _InboxPageState extends State<InboxPage> {
   @override
   void initState() {
     super.initState();
-    context.read<InboxCubit>().initializeInbox();
+    context.read<InboxCubit>().loadInbox();
     _scrollController.addListener(_listenForLoadNewData);
   }
 
@@ -57,6 +57,12 @@ class _InboxPageState extends State<InboxPage> {
 
   @override
   Widget build(BuildContext context) {
+    final safeAreaPadding = MediaQuery.of(context).padding;
+    final availableHeight = MediaQuery.of(context).size.height -
+        kToolbarHeight -
+        kBottomNavigationBarHeight -
+        safeAreaPadding.top -
+        safeAreaPadding.bottom;
     return Scaffold(
       drawer: const AppDrawer(),
       floatingActionButton: BlocBuilder<InboxCubit, InboxState>(
@@ -76,97 +82,105 @@ class _InboxPageState extends State<InboxPage> {
           );
         },
       ),
-      body: RefreshIndicator(
-        edgeOffset: 78,
-        onRefresh: () => context.read<InboxCubit>().initializeInbox(),
-        child: NestedScrollView(
-          headerSliverBuilder: (context, innerBoxIsScrolled) => [
-            SearchAppBar(
-              hintText: S.of(context).documentSearchSearchDocuments,
-              onOpenSearch: showDocumentSearchPage,
-            ),
-          ],
-          body: BlocBuilder<InboxCubit, InboxState>(
-            builder: (context, state) {
-              if (!state.hasLoaded) {
-                return const CustomScrollView(
-                  physics: NeverScrollableScrollPhysics(),
-                  slivers: [DocumentsListLoadingWidget()],
-                );
-              }
-
-              if (state.documents.isEmpty) {
-                return InboxEmptyWidget(
-                  emptyStateRefreshIndicatorKey: _emptyStateRefreshIndicatorKey,
-                );
-              }
-
-              // Build a list of slivers alternating between SliverToBoxAdapter
-              // (group header) and a SliverList (inbox items).
-              final List<Widget> slivers = _groupByDate(state.documents)
-                  .entries
-                  .map(
-                    (entry) => [
-                      SliverToBoxAdapter(
-                        child: Align(
-                          alignment: Alignment.centerLeft,
-                          child: ClipRRect(
-                            borderRadius: BorderRadius.circular(32.0),
-                            child: Text(
-                              entry.key,
-                              style: Theme.of(context).textTheme.bodySmall,
-                              textAlign: TextAlign.center,
-                            ).padded(),
-                          ),
-                        ).paddedOnly(top: 8.0),
-                      ),
-                      SliverList(
-                        delegate: SliverChildBuilderDelegate(
-                          childCount: entry.value.length,
-                          (context, index) {
-                            if (index < entry.value.length - 1) {
-                              return Column(
-                                children: [
-                                  _buildListItem(
-                                    entry.value[index],
-                                  ),
-                                  const Divider(
-                                    indent: 16,
-                                    endIndent: 16,
-                                  ),
-                                ],
-                              );
-                            }
-                            return _buildListItem(
-                              entry.value[index],
-                            );
-                          },
+      body: BlocBuilder<InboxCubit, InboxState>(
+        builder: (context, state) {
+          return SafeArea(
+            top: true,
+            child: Builder(
+              builder: (context) {
+                // Build a list of slivers alternating between SliverToBoxAdapter
+                // (group header) and a SliverList (inbox items).
+                final List<Widget> slivers = _groupByDate(state.documents)
+                    .entries
+                    .map(
+                      (entry) => [
+                        SliverToBoxAdapter(
+                          child: Align(
+                            alignment: Alignment.centerLeft,
+                            child: ClipRRect(
+                              borderRadius: BorderRadius.circular(32.0),
+                              child: Text(
+                                entry.key,
+                                style: Theme.of(context).textTheme.bodySmall,
+                                textAlign: TextAlign.center,
+                              ).padded(),
+                            ),
+                          ).paddedOnly(top: 8.0),
                         ),
-                      ),
-                    ],
-                  )
-                  .flattened
-                  .toList()
-                ..add(const SliverToBoxAdapter(child: SizedBox(height: 78)));
-              //                              edgeOffset: kToolbarHeight,
+                        SliverList(
+                          delegate: SliverChildBuilderDelegate(
+                            childCount: entry.value.length,
+                            (context, index) {
+                              if (index < entry.value.length - 1) {
+                                return Column(
+                                  children: [
+                                    _buildListItem(
+                                      entry.value[index],
+                                    ),
+                                    const Divider(
+                                      indent: 16,
+                                      endIndent: 16,
+                                    ),
+                                  ],
+                                );
+                              }
+                              return _buildListItem(
+                                entry.value[index],
+                              );
+                            },
+                          ),
+                        ),
+                      ],
+                    )
+                    .flattened
+                    .toList()
+                  ..add(const SliverToBoxAdapter(child: SizedBox(height: 78)));
+                //                              edgeOffset: kToolbarHeight,
 
-              return CustomScrollView(
-                controller: _scrollController,
-                slivers: [
-                  SliverToBoxAdapter(
-                    child: HintCard(
-                      show: !state.isHintAcknowledged,
-                      hintText: S.of(context).inboxPageUsageHintText,
-                      onHintAcknowledged: () =>
-                          context.read<InboxCubit>().acknowledgeHint(),
-                    ),
+                return RefreshIndicator(
+                  edgeOffset: kToolbarHeight,
+                  onRefresh: context.read<InboxCubit>().reload,
+                  child: CustomScrollView(
+                    physics: state.documents.isEmpty
+                        ? const NeverScrollableScrollPhysics()
+                        : const AlwaysScrollableScrollPhysics(),
+                    controller: _scrollController,
+                    slivers: [
+                      SearchAppBar(
+                        hintText: S.of(context).documentSearchSearchDocuments,
+                        onOpenSearch: showDocumentSearchPage,
+                      ),
+                      if (state.documents.isEmpty)
+                        SliverToBoxAdapter(
+                          child: SizedBox(
+                            height: availableHeight,
+                            child: Center(
+                              child: InboxEmptyWidget(
+                                emptyStateRefreshIndicatorKey:
+                                    _emptyStateRefreshIndicatorKey,
+                              ),
+                            ),
+                          ),
+                        )
+                      else if (!state.hasLoaded)
+                        DocumentsListLoadingWidget()
+                      else
+                        SliverToBoxAdapter(
+                          child: HintCard(
+                            show: !state.isHintAcknowledged,
+                            hintText: S.of(context).inboxPageUsageHintText,
+                            onHintAcknowledged: () =>
+                                context.read<InboxCubit>().acknowledgeHint(),
+                          ),
+                        ),
+                      ...slivers,
+                    ],
                   ),
-                  ...slivers,
-                ],
-              );
-            },
-          ),
-        ),
+                );
+              },
+            ),
+          );
+        },
       ),
     );
   }
@@ -191,12 +205,7 @@ class _InboxPageState extends State<InboxPage> {
       ).padded(),
       confirmDismiss: (_) => _onItemDismissed(doc),
       key: UniqueKey(),
-      child: InboxItem(
-        document: doc,
-        onDocumentUpdated: (document) {
-          context.read<InboxCubit>().replaceUpdatedDocument(document);
-        },
-      ),
+      child: InboxItem(document: doc),
     );
   }
 

lib/features/inbox/view/widgets/inbox_empty_widget.dart

@@ -16,7 +16,7 @@ class InboxEmptyWidget extends StatelessWidget {
   Widget build(BuildContext context) {
     return RefreshIndicator(
       key: _emptyStateRefreshIndicatorKey,
-      onRefresh: () => context.read<InboxCubit>().initializeInbox(),
+      onRefresh: () => context.read<InboxCubit>().loadInbox(),
       child: Center(
         child: Column(
           mainAxisSize: MainAxisSize.max,

lib/features/inbox/view/widgets/inbox_item.dart

@@ -1,13 +1,8 @@
 import 'package:flutter/material.dart';
 import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:paperless_api/paperless_api.dart';
-import 'package:paperless_mobile/core/repository/provider/label_repositories_provider.dart';
-import 'package:paperless_mobile/core/repository/state/impl/correspondent_repository_state.dart';
-import 'package:paperless_mobile/core/repository/state/impl/document_type_repository_state.dart';
 import 'package:paperless_mobile/core/workarounds/colored_chip.dart';
 import 'package:paperless_mobile/extensions/flutter_extensions.dart';
-import 'package:paperless_mobile/features/document_details/bloc/document_details_cubit.dart';
-import 'package:paperless_mobile/features/document_details/view/pages/document_details_page.dart';
 import 'package:paperless_mobile/features/documents/view/widgets/delete_document_confirmation_dialog.dart';
 import 'package:paperless_mobile/features/documents/view/widgets/document_preview.dart';
 import 'package:paperless_mobile/features/inbox/bloc/inbox_cubit.dart';
@@ -19,12 +14,10 @@ import 'package:paperless_mobile/routes/document_details_route.dart';
 class InboxItem extends StatefulWidget {
   static const _a4AspectRatio = 1 / 1.4142;
 
-  final void Function(DocumentModel model) onDocumentUpdated;
   final DocumentModel document;
   const InboxItem({
     super.key,
     required this.document,
-    required this.onDocumentUpdated,
   });
 
   @override
@@ -41,17 +34,14 @@ class _InboxItemState extends State<InboxItem> {
     return GestureDetector(
       behavior: HitTestBehavior.translucent,
       onTap: () async {
-        final updatedDocument = await Navigator.pushNamed(
+        Navigator.pushNamed(
           context,
           DocumentDetailsRoute.routeName,
           arguments: DocumentDetailsRouteArguments(
             document: widget.document,
             isLabelClickable: false,
           ),
-        ) as DocumentModel?;
-        if (updatedDocument != null) {
-          widget.onDocumentUpdated(updatedDocument);
-        }
+        );
       },
       child: SizedBox(
         height: 200,
@@ -104,12 +94,12 @@ class _InboxItemState extends State<InboxItem> {
     );
     final actions = [
       _buildAssignAsnAction(chipShape, context),
-      const SizedBox(width: 4.0),
+      const SizedBox(width: 8.0),
       ColoredChipWrapper(
         child: ActionChip(
           avatar: const Icon(Icons.delete_outline),
           shape: chipShape,
-          label: const Text("Delete document"),
+          label: Text(S.of(context).inboxActionDeleteDocument),
           onPressed: () async {
             final shouldDelete = await showDialog<bool>(
                   context: context,
@@ -124,6 +114,7 @@ class _InboxItemState extends State<InboxItem> {
         ),
       ),
     ];
+
     // return FutureBuilder<FieldSuggestions>(
     //   future: _fieldSuggestions,
     //   builder: (context, snapshot) {
@@ -151,12 +142,14 @@ class _InboxItemState extends State<InboxItem> {
           mainAxisSize: MainAxisSize.min,
           children: [
             const Icon(Icons.bolt_outlined),
-            SizedBox(
-              width: 40,
+            ConstrainedBox(
+              constraints: const BoxConstraints(
+                maxWidth: 50,
+              ),
               child: Text(
                 S.of(context).inboxPageQuickActionsLabel,
                 textAlign: TextAlign.center,
-                maxLines: 2,
+                maxLines: 3,
                 style: Theme.of(context).textTheme.labelSmall,
               ),
             ),
@@ -199,7 +192,7 @@ class _InboxItemState extends State<InboxItem> {
             ? Text(
                 '${S.of(context).documentArchiveSerialNumberPropertyShortLabel} #${widget.document.archiveSerialNumber}',
               )
-            : const Text("Assign ASN"),
+            : Text(S.of(context).inboxActionAssignAsn),
         onPressed: !hasAsn
             ? () {
                 setState(() {
@@ -233,7 +226,7 @@ class _InboxItemState extends State<InboxItem> {
         Icons.description_outlined,
         size: Theme.of(context).textTheme.bodyMedium?.fontSize,
       ),
-      LabelText<DocumentType, DocumentTypeRepositoryState>(
+      LabelText<DocumentType>(
         id: widget.document.documentType,
         style: Theme.of(context).textTheme.bodyMedium,
         placeholder: "-",
@@ -247,7 +240,7 @@ class _InboxItemState extends State<InboxItem> {
         Icons.person_outline,
         size: Theme.of(context).textTheme.bodyMedium?.fontSize,
       ),
-      LabelText<Correspondent, CorrespondentRepositoryState>(
+      LabelText<Correspondent>(
         id: widget.document.correspondent,
         style: Theme.of(context).textTheme.bodyMedium,
         placeholder: "-",