From 3a0cc643e55fa20859aa72f7a57f8b18c6fca595 Mon Sep 17 00:00:00 2001 From: Xevion Date: Fri, 22 Sep 2023 23:41:22 -0500 Subject: [PATCH] Add concerns section to README, remove list Qt files step, name checkout step --- .github/workflows/build.yaml | 6 ++---- README.md | 14 ++++++++++++++ 2 files changed, 16 insertions(+), 4 deletions(-) diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml index 7117456..5363364 100644 --- a/.github/workflows/build.yaml +++ b/.github/workflows/build.yaml @@ -23,10 +23,8 @@ jobs: arch: "gcc_64" install-deps: "true" - - name: List files in Qt - run: find ${{env.Qt5_Dir}} - - - uses: actions/checkout@v3 + - name: Checkout repository + uses: actions/checkout@v3 - name: Configure CMake run: cmake -B '${{github.workspace}}'/build diff --git a/README.md b/README.md index 818aaf1..3674c04 100644 --- a/README.md +++ b/README.md @@ -6,6 +6,20 @@ Feature Targets: - Cross platform (Windows, Linux, Mac) - Automatic build scripts with Workflows +## Concerns + +- Testing on VDI + - It's important that these builds are fully compatible on the VDI machines (Windows, no admin privileges). + - Potential for integration testing on VDI-like machines? +- MacOS ARM/Intel support + - ARM machines are notorious for not supporting lots of software, but many students have Macs. Testing on both architectures is important. +- Release/Debug builds + - It would be good to have debug builds availble for testing. +- Runtime & Build-time Version + - Version, environment type & target information is important to have available at both runtime & build time. + - Builds must have artifacts that contain this information automatically. + - Commit hash, build date, build type, target platform, etc. + ## VS Code - Requirements