From afe6ad6bfcc3bed5eebfddee187e4e8c06a6b9ec Mon Sep 17 00:00:00 2001 From: Svilen Markov <7613769+svilenmarkov@users.noreply.github.com> Date: Sun, 17 Nov 2024 10:06:54 +0000 Subject: [PATCH] Don't focus new tab on middle click This is more in line with how the browser behaves on middle click --- internal/assets/static/js/main.js | 2 +- internal/assets/static/js/utils.js | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/internal/assets/static/js/main.js b/internal/assets/static/js/main.js index 29d2738..114cbde 100644 --- a/internal/assets/static/js/main.js +++ b/internal/assets/static/js/main.js @@ -262,7 +262,7 @@ function setupGroups() { return; } - openURLInNewTab(title.dataset.titleUrl); + openURLInNewTab(title.dataset.titleUrl, false); event.preventDefault(); }); } diff --git a/internal/assets/static/js/utils.js b/internal/assets/static/js/utils.js index ae2f6e0..5f5b2c7 100644 --- a/internal/assets/static/js/utils.js +++ b/internal/assets/static/js/utils.js @@ -28,6 +28,8 @@ export function clamp(value, min, max) { return Math.min(Math.max(value, min), max); } -export function openURLInNewTab(url) { - window.open(url, '_blank', 'noopener,noreferrer')?.focus(); +export function openURLInNewTab(url, focus = true) { + const newWindow = window.open(url, '_blank', 'noopener,noreferrer'); + + if (focus && newWindow != null) newWindow.focus(); }