19.00

CPP/7zip/UI/Client7z/makefile

@@ -1,28 +1,28 @@
-PROG = 7zcl.exe
-MY_CONSOLE = 1
-
-CURRENT_OBJS = \
-  $O\Client7z.obj \
-
-COMMON_OBJS = \
-  $O\IntToString.obj \
-  $O\NewHandler.obj \
-  $O\MyString.obj \
-  $O\StringConvert.obj \
-  $O\StringToInt.obj \
-  $O\MyVector.obj \
-  $O\Wildcard.obj \
-
-WIN_OBJS = \
-  $O\DLL.obj \
-  $O\FileDir.obj \
-  $O\FileFind.obj \
-  $O\FileIO.obj \
-  $O\FileName.obj \
-  $O\PropVariant.obj \
-  $O\PropVariantConv.obj \
-
-7ZIP_COMMON_OBJS = \
-  $O\FileStreams.obj \
-
-!include "../../7zip.mak"
+PROG = 7zcl.exe
+MY_CONSOLE = 1
+
+CURRENT_OBJS = \
+  $O\Client7z.obj \
+
+COMMON_OBJS = \
+  $O\IntToString.obj \
+  $O\NewHandler.obj \
+  $O\MyString.obj \
+  $O\StringConvert.obj \
+  $O\StringToInt.obj \
+  $O\MyVector.obj \
+  $O\Wildcard.obj \
+
+WIN_OBJS = \
+  $O\DLL.obj \
+  $O\FileDir.obj \
+  $O\FileFind.obj \
+  $O\FileIO.obj \
+  $O\FileName.obj \
+  $O\PropVariant.obj \
+  $O\PropVariantConv.obj \
+
+7ZIP_COMMON_OBJS = \
+  $O\FileStreams.obj \
+
+!include "../../7zip.mak"

CPP/7zip/UI/Common/ArchiveName.cpp

@@ -99,9 +99,28 @@ UString CreateArchiveName(const UStringVector &paths, const NFind::CFileInfo *fi
     name = Get_Correct_FsFile_Name(fs2us(CreateArchiveName2(us2fs(paths.Front()), fromPrev, keepName)));
   }
 
+  UStringVector names;
+
+  {
+    FOR_VECTOR (i, paths)
+    {
+      NFind::CFileInfo fi2;
+      const NFind::CFileInfo *fp;
+      if (fi && paths.Size() == 1)
+        fp = fi;
+      else
+      {
+        if (!fi2.Find(us2fs(paths[i])))
+          continue;
+        fp = &fi2;
+      }
+      names.Add(fs2us(fp->Name));
+    }
+  }
+
   UString postfix;
   UInt32 index = 1;
-  
+
   for (;;)
   {
     // we don't want cases when we include archive to itself.
@@ -113,22 +132,10 @@ UString CreateArchiveName(const UStringVector &paths, const NFind::CFileInfo *fi
     const UString name2_wim = name2 + L".wim";
     
     unsigned i = 0;
-    
-    for (i = 0; i < paths.Size(); i++)
-    {
-      const UString &fn = paths[i];
-      NFind::CFileInfo fi2;
 
-      const NFind::CFileInfo *fp;
-      if (fi && paths.Size() == 1)
-        fp = fi;
-      else
-      {
-        if (!fi2.Find(us2fs(fn)))
-          continue;
-        fp = &fi2;
-      }
-      const UString fname = fs2us(fp->Name);
+    for (i = 0; i < names.Size(); i++)
+    {
+      const UString &fname = names[i];
       if (   0 == CompareFileNames(fname, name2_zip)
           || 0 == CompareFileNames(fname, name2_7z)
           || 0 == CompareFileNames(fname, name2_tar)
@@ -136,7 +143,7 @@ UString CreateArchiveName(const UStringVector &paths, const NFind::CFileInfo *fi
         break;
     }
     
-    if (i == paths.Size())
+    if (i == names.Size())
       break;
     index++;
     postfix = "_";

CPP/7zip/UI/Common/ArchiveOpenCallback.cpp

@@ -102,7 +102,14 @@ STDMETHODIMP COpenCallbackImp::GetStream(const wchar_t *name, IInStream **inStre
   // if (!allowAbsVolPaths)
   if (!IsSafePath(name2))
     return S_FALSE;
-  
+
+  // #ifdef _WIN32
+  // we don't want to support wildcards in names here here
+  if (name2.Find(L'?') >= 0 ||
+      name2.Find(L'*') >= 0)
+    return S_FALSE;
+  // #endif
+
   #endif
 
 

CPP/7zip/UI/Common/Bench.cpp

@@ -29,7 +29,6 @@
 #endif
 
 #include "../../../../C/7zCrc.h"
-#include "../../../../C/Alloc.h"
 #include "../../../../C/CpuArch.h"
 
 #ifndef _7ZIP_ST
@@ -47,6 +46,7 @@
 
 
 #include "../../../Common/IntToString.h"
+#include "../../../Common/MyBuffer2.h"
 #include "../../../Common/StringConvert.h"
 #include "../../../Common/StringToInt.h"
 
@@ -94,80 +94,33 @@ static const UInt32 kAdditionalSize = (1 << 16);
 static const UInt32 kCompressedAdditionalSize = (1 << 10);
 static const UInt32 kMaxLzmaPropSize = 5;
 
+
+
+#define ALLOC_WITH_HRESULT(_buffer_, _size_) \
+  (_buffer_)->Alloc(_size_); \
+  if (!(_buffer_)->IsAllocated()) return E_OUTOFMEMORY;
+
+
 class CBaseRandomGenerator
 {
   UInt32 A1;
   UInt32 A2;
+  UInt32 Salt;
 public:
-  CBaseRandomGenerator() { Init(); }
+  CBaseRandomGenerator(UInt32 salt = 0): Salt(salt) { Init(); }
   void Init() { A1 = 362436069; A2 = 521288629;}
   UInt32 GetRnd()
   {
-    return
+    return Salt ^
+    (
       ((A1 = 36969 * (A1 & 0xffff) + (A1 >> 16)) << 16) +
-      ((A2 = 18000 * (A2 & 0xffff) + (A2 >> 16)) );
+      ((A2 = 18000 * (A2 & 0xffff) + (A2 >> 16)) )
+    );
   }
 };
 
 
-static const unsigned kBufferAlignment = 1 << 4;
-
-struct CBenchBuffer
-{
-  size_t BufferSize;
-
-  #ifdef _WIN32
-
-  Byte *Buffer;
-
-  CBenchBuffer(): BufferSize(0), Buffer(NULL) {}
-  ~CBenchBuffer() { ::MidFree(Buffer); }
-  
-  void AllocAlignedMask(size_t size, size_t)
-  {
-    ::MidFree(Buffer);
-    BufferSize = 0;
-    Buffer = (Byte *)::MidAlloc(size);
-    if (Buffer)
-      BufferSize = size;
-  }
-  
-  #else
-  
-  Byte *Buffer;
-  Byte *_bufBase;
-
-  CBenchBuffer(): BufferSize(0), Buffer(NULL), _bufBase(NULL){}
-  ~CBenchBuffer() { ::MidFree(_bufBase); }
-  
-  void AllocAlignedMask(size_t size, size_t alignMask)
-  {
-    ::MidFree(_bufBase);
-    Buffer = NULL;
-    BufferSize = 0;
-    _bufBase = (Byte *)::MidAlloc(size + alignMask);
-    
-    if (_bufBase)
-    {
-      // Buffer = (Byte *)(((uintptr_t)_bufBase + alignMask) & ~(uintptr_t)alignMask);
-         Buffer = (Byte *)(((ptrdiff_t)_bufBase + alignMask) & ~(ptrdiff_t)alignMask);
-      BufferSize = size;
-    }
-  }
-
-  #endif
-
-  bool Alloc(size_t size)
-  {
-    if (Buffer && BufferSize == size)
-      return true;
-    AllocAlignedMask(size, kBufferAlignment - 1);
-    return (Buffer != NULL || size == 0);
-  }
-};
-
-
-class CBenchRandomGenerator: public CBenchBuffer
+class CBenchRandomGenerator: public CAlignedBuffer
 {
   static UInt32 GetVal(UInt32 &res, unsigned numBits)
   {
@@ -184,23 +137,22 @@ class CBenchRandomGenerator: public CBenchBuffer
 
 public:
   
-  void GenerateSimpleRandom(CBaseRandomGenerator *_RG_)
+  void GenerateSimpleRandom(UInt32 salt)
   {
-    CBaseRandomGenerator rg = *_RG_;
-    const size_t bufSize = BufferSize;
-    Byte *buf = Buffer;
+    CBaseRandomGenerator rg(salt);
+    const size_t bufSize = Size();
+    Byte *buf = (Byte *)*this;
     for (size_t i = 0; i < bufSize; i++)
       buf[i] = (Byte)rg.GetRnd();
-    *_RG_ = rg;
   }
 
-  void GenerateLz(unsigned dictBits, CBaseRandomGenerator *_RG_)
+  void GenerateLz(unsigned dictBits, UInt32 salt)
   {
-    CBaseRandomGenerator rg = *_RG_;
+    CBaseRandomGenerator rg(salt);
     UInt32 pos = 0;
     UInt32 rep0 = 1;
-    const size_t bufSize = BufferSize;
-    Byte *buf = Buffer;
+    const size_t bufSize = Size();
+    Byte *buf = (Byte *)*this;
     unsigned posBits = 1;
     
     while (pos < bufSize)
@@ -255,8 +207,6 @@ public:
           *dest++ = *src++;
       }
     }
-
-    *_RG_ = rg;
   }
 };
 
@@ -297,7 +247,7 @@ STDMETHODIMP CBenchmarkInStream::Read(void *data, UInt32 size, UInt32 *processed
   
 class CBenchmarkOutStream:
   public ISequentialOutStream,
-  public CBenchBuffer,
+  public CAlignedBuffer,
   public CMyUnknownImp
 {
   // bool _overflow;
@@ -325,13 +275,13 @@ public:
 
 STDMETHODIMP CBenchmarkOutStream::Write(const void *data, UInt32 size, UInt32 *processedSize)
 {
-  size_t curSize = BufferSize - Pos;
+  size_t curSize = Size() - Pos;
   if (curSize > size)
     curSize = size;
   if (curSize != 0)
   {
     if (RealCopy)
-      memcpy(Buffer + Pos, data, curSize);
+      memcpy(((Byte *)*this) + Pos, data, curSize);
     if (CalcCrc)
       Crc = CrcUpdate(Crc, data, curSize);
     Pos += curSize;
@@ -686,20 +636,39 @@ UInt64 GetDecompressRating(UInt64 elapsedTime, UInt64 freq, UInt64 outSize, UInt
   return props.GetDecompressRating(elapsedTime, freq, outSize, inSize, numIterations);
 }
 
+
+
+
+#ifndef _7ZIP_ST
+struct CBenchSyncCommon
+{
+  bool ExitMode;
+  NSynchronization::CManualResetEvent StartEvent;
+
+  CBenchSyncCommon(): ExitMode(false) {}
+};
+#endif
+
+
 struct CEncoderInfo;
 
 struct CEncoderInfo
 {
   #ifndef _7ZIP_ST
   NWindows::CThread thread[2];
+  NSynchronization::CManualResetEvent ReadyEvent;
   UInt32 NumDecoderSubThreads;
+  CBenchSyncCommon *Common;
   #endif
+
   CMyComPtr<ICompressCoder> _encoder;
   CMyComPtr<ICompressFilter> _encoderFilter;
   CBenchProgressInfo *progressInfoSpec[2];
   CMyComPtr<ICompressProgressInfo> progressInfo[2];
   UInt64 NumIterations;
 
+  UInt32 Salt;
+
   #ifdef USE_ALLOCA
   size_t AllocaSize;
   #endif
@@ -738,22 +707,25 @@ struct CEncoderInfo
   const Byte *fileData;
   CBenchRandomGenerator rg;
 
-  CBenchBuffer rgCopy; // it must be 16-byte aligned !!!
+  CAlignedBuffer rgCopy; // it must be 16-byte aligned !!!
   CBenchmarkOutStream *propStreamSpec;
   CMyComPtr<ISequentialOutStream> propStream;
 
-  // for decode
+  unsigned generateDictBits;
   COneMethodInfo _method;
+  
+  // for decode
   size_t _uncompressedDataSize;
 
-  HRESULT Init(
-      const COneMethodInfo &method,
-      unsigned generateDictBits,
-      CBaseRandomGenerator *rg);
+  HRESULT Generate();
   HRESULT Encode();
   HRESULT Decode(UInt32 decoderIndex);
 
   CEncoderInfo():
+    #ifndef _7ZIP_ST
+    Common(NULL),
+    #endif
+    Salt(0),
     fileData(NULL),
     CheckCrc_Enc(true),
     CheckCrc_Dec(true),
@@ -772,14 +744,15 @@ struct CEncoderInfo
       #endif
 
       res = encoder->Encode();
-      encoder->Results[0] = res;
     }
     catch(...)
     {
       res = E_FAIL;
     }
+    encoder->Results[0] = res;
     if (res != S_OK)
       encoder->progressInfoSpec[0]->Status->SetResult(res);
+    encoder->ReadyEvent.Set();
     return 0;
   }
   
@@ -798,7 +771,12 @@ struct CEncoderInfo
 
   HRESULT CreateEncoderThread()
   {
-    return thread[0].Create(EncodeThreadFunction, this);
+    WRes res = 0;
+    if (!ReadyEvent.IsCreated())
+      res = ReadyEvent.Create();
+    if (res == 0)
+      res = thread[0].Create(EncodeThreadFunction, this);
+    return HRESULT_FROM_WIN32(res);
   }
 
   HRESULT CreateDecoderThread(unsigned index, bool callbackMode
@@ -823,11 +801,10 @@ struct CEncoderInfo
 };
 
 
-HRESULT CEncoderInfo::Init(
-    const COneMethodInfo &method,
-    unsigned generateDictBits,
-    CBaseRandomGenerator *rgLoc)
+HRESULT CEncoderInfo::Generate()
 {
+  const COneMethodInfo &method = _method;
+
   // we need extra space, if input data is already compressed
   const size_t kCompressedBufferSize =
       kCompressedAdditionalSize +
@@ -841,40 +818,39 @@ HRESULT CEncoderInfo::Init(
   
   if (!fileData)
   {
-    if (!rg.Alloc(kBufferSize))
-      return E_OUTOFMEMORY;
+    ALLOC_WITH_HRESULT(&rg, kBufferSize);
     
     // DWORD ttt = GetTickCount();
     if (generateDictBits == 0)
-      rg.GenerateSimpleRandom(rgLoc);
+      rg.GenerateSimpleRandom(Salt);
     else
-      rg.GenerateLz(generateDictBits, rgLoc);
+      rg.GenerateLz(generateDictBits, Salt);
     // printf("\n%d\n            ", GetTickCount() - ttt);
 
-    crc = CrcCalc(rg.Buffer, rg.BufferSize);
-    uncompressedDataPtr = rg.Buffer;
+    crc = CrcCalc((const Byte *)rg, rg.Size());
+    uncompressedDataPtr = (const Byte *)rg;
   }
   
   if (_encoderFilter)
   {
-    if (!rgCopy.Alloc(kBufferSize))
-      return E_OUTOFMEMORY;
+    ALLOC_WITH_HRESULT(&rgCopy, kBufferSize);
   }
 
 
-  outStreamSpec = new CBenchmarkOutStream;
-  outStream = outStreamSpec;
-  if (!outStreamSpec->Alloc(kCompressedBufferSize))
-    return E_OUTOFMEMORY;
+  if (!outStream)
+  {
+    outStreamSpec = new CBenchmarkOutStream;
+    outStream = outStreamSpec;
+  }
+
+  ALLOC_WITH_HRESULT(outStreamSpec, kCompressedBufferSize)
 
-  propStreamSpec = 0;
   if (!propStream)
   {
     propStreamSpec = new CBenchmarkOutStream;
     propStream = propStreamSpec;
   }
-  if (!propStreamSpec->Alloc(kMaxLzmaPropSize))
-    return E_OUTOFMEMORY;
+  ALLOC_WITH_HRESULT(propStreamSpec, kMaxLzmaPropSize);
   propStreamSpec->Init(true, false);
   
  
@@ -961,6 +937,28 @@ static void My_FilterBench(ICompressFilter *filter, Byte *data, size_t size)
 
 HRESULT CEncoderInfo::Encode()
 {
+  RINOK(Generate());
+
+  #ifndef _7ZIP_ST
+  if (Common)
+  {
+    Results[0] = S_OK;
+    WRes wres = ReadyEvent.Set();
+    if (wres == 0)
+      wres = Common->StartEvent.Lock();
+    if (wres != 0)
+      return HRESULT_FROM_WIN32(wres);
+    if (Common->ExitMode)
+      return S_OK;
+  }
+  else
+  #endif
+  {
+    CBenchProgressInfo *bpi = progressInfoSpec[0];
+    bpi->SetStartTime();
+  }
+
+
   CBenchInfo &bi = progressInfoSpec[0]->BenchInfo;
   bi.UnpackSize = 0;
   bi.PackSize = 0;
@@ -997,10 +995,10 @@ HRESULT CEncoderInfo::Encode()
     
     if (_encoderFilter)
     {
-      memcpy(rgCopy.Buffer, uncompressedDataPtr, kBufferSize);
+      memcpy((Byte *)rgCopy, uncompressedDataPtr, kBufferSize);
       _encoderFilter->Init();
-      My_FilterBench(_encoderFilter, rgCopy.Buffer, kBufferSize);
-      RINOK(WriteStream(outStream, rgCopy.Buffer, kBufferSize));
+      My_FilterBench(_encoderFilter, (Byte *)rgCopy, kBufferSize);
+      RINOK(WriteStream(outStream, (const Byte *)rgCopy, kBufferSize));
     }
     else
     {
@@ -1078,7 +1076,7 @@ HRESULT CEncoderInfo::Decode(UInt32 decoderIndex)
   
   if (setDecProps)
   {
-    RINOK(setDecProps->SetDecoderProperties2(propStreamSpec->Buffer, (UInt32)propStreamSpec->Pos));
+    RINOK(setDecProps->SetDecoderProperties2((const Byte *)*propStreamSpec, (UInt32)propStreamSpec->Pos));
   }
 
   {
@@ -1106,7 +1104,7 @@ HRESULT CEncoderInfo::Decode(UInt32 decoderIndex)
       prev = pi->BenchInfo.UnpackSize;
     }
 
-    inStreamSpec->Init(outStreamSpec->Buffer, compressedSize);
+    inStreamSpec->Init((const Byte *)*outStreamSpec, compressedSize);
     crcOutStreamSpec->Init();
     
     UInt64 outSize = kBufferSize;
@@ -1114,12 +1112,12 @@ HRESULT CEncoderInfo::Decode(UInt32 decoderIndex)
     
     if (_decoderFilter)
     {
-      if (compressedSize > rgCopy.BufferSize)
+      if (compressedSize > rgCopy.Size())
         return E_FAIL;
-      memcpy(rgCopy.Buffer, outStreamSpec->Buffer, compressedSize);
+      memcpy((Byte *)rgCopy, (const Byte *)*outStreamSpec, compressedSize);
       _decoderFilter->Init();
-      My_FilterBench(_decoderFilter, rgCopy.Buffer, compressedSize);
-      RINOK(WriteStream(crcOutStream, rgCopy.Buffer, compressedSize));
+      My_FilterBench(_decoderFilter, (Byte *)rgCopy, compressedSize);
+      RINOK(WriteStream(crcOutStream, (const Byte *)rgCopy, compressedSize));
     }
     else
     {
@@ -1157,6 +1155,57 @@ static UInt64 GetNumIterations(UInt64 numCommands, UInt64 complexInCommands)
 }
 
 
+
+#ifndef _7ZIP_ST
+
+// ---------- CBenchThreadsFlusher ----------
+
+struct CBenchThreadsFlusher
+{
+  CBenchEncoders *EncodersSpec;
+  CBenchSyncCommon Common;
+  unsigned NumThreads;
+  bool NeedClose;
+
+  CBenchThreadsFlusher(): NumThreads(0), NeedClose(false) {}
+  
+  ~CBenchThreadsFlusher()
+  {
+    StartAndWait(true);
+  }
+
+  WRes StartAndWait(bool exitMode = false);
+};
+
+
+WRes CBenchThreadsFlusher::StartAndWait(bool exitMode)
+{
+  if (!NeedClose)
+    return 0;
+
+  Common.ExitMode = exitMode;
+  WRes res = Common.StartEvent.Set();
+
+  for (unsigned i = 0; i < NumThreads; i++)
+  {
+    NWindows::CThread &t = EncodersSpec->encoders[i].thread[0];
+    if (t.IsCreated())
+    {
+      WRes res2 = t.Wait();
+      if (res2 == 0)
+        res2 = t.Close();
+      if (res == S_OK)
+        res = res2;
+    }
+  }
+  NeedClose = false;
+  return res;
+}
+
+#endif
+
+
+
 static HRESULT MethodBench(
     DECL_EXTERNAL_CODECS_LOC_VARS
     UInt64 complexInCommands,
@@ -1208,6 +1257,8 @@ static HRESULT MethodBench(
         numSubDecoderThreads = 2;
       }
     }
+
+  bool mtEncMode = (numEncoderThreads > 1);
   #endif
 
   CBenchEncoders encodersSpec(numEncoderThreads);
@@ -1247,9 +1298,6 @@ static HRESULT MethodBench(
     }
   }
 
-  CBaseRandomGenerator rg;
-  rg.Init();
-
   UInt32 crc = 0;
   if (fileData)
     crc = CrcCalc(fileData, uncompressedDataSize);
@@ -1258,22 +1306,38 @@ static HRESULT MethodBench(
   {
     CEncoderInfo &encoder = encoders[i];
     encoder._method = method;
+    encoder.generateDictBits = generateDictBits;
     encoder._uncompressedDataSize = uncompressedDataSize;
     encoder.kBufferSize = uncompressedDataSize;
     encoder.fileData = fileData;
     encoder.crc = crc;
-
-    RINOK(encoders[i].Init(method, generateDictBits, &rg));
   }
 
   CBenchProgressStatus status;
   status.Res = S_OK;
   status.EncodeMode = true;
 
+  #ifndef _7ZIP_ST
+  CBenchThreadsFlusher encoderFlusher;
+  if (mtEncMode)
+  {
+    WRes wres = encoderFlusher.Common.StartEvent.Create();
+    if (wres != 0)
+      return HRESULT_FROM_WIN32(wres);
+    encoderFlusher.NumThreads = numEncoderThreads;
+    encoderFlusher.EncodersSpec = &encodersSpec;
+    encoderFlusher.NeedClose = true;
+  }
+  #endif
+
   for (i = 0; i < numEncoderThreads; i++)
   {
     CEncoderInfo &encoder = encoders[i];
     encoder.NumIterations = GetNumIterations(benchProps->GeComprCommands(uncompressedDataSize), complexInCommands);
+    encoder.Salt = g_CrcTable[i & 0xFF];
+    encoder.Salt ^= (g_CrcTable[(i >> 8) & 0xFF] << 3);
+    // (g_CrcTable[0] == 0), and (encoder.Salt == 0) for first thread
+    // printf(" %8x", encoder.Salt);
 
     for (int j = 0; j < 2; j++)
     {
@@ -1288,30 +1352,50 @@ static HRESULT MethodBench(
       CBenchProgressInfo *bpi = encoder.progressInfoSpec[0];
       bpi->Callback = callback;
       bpi->BenchInfo.NumIterations = numEncoderThreads;
-      bpi->SetStartTime();
     }
 
     #ifndef _7ZIP_ST
-    if (numEncoderThreads > 1)
+    if (mtEncMode)
     {
       #ifdef USE_ALLOCA
       encoder.AllocaSize = (i * 16 * 21) & 0x7FF;
       #endif
 
+      encoder.Common = &encoderFlusher.Common;
       RINOK(encoder.CreateEncoderThread())
     }
-    else
     #endif
-    {
-      RINOK(encoder.Encode());
-    }
   }
-  
+
+  if (printCallback)
+  {
+    RINOK(printCallback->CheckBreak());
+  }
+
   #ifndef _7ZIP_ST
-  if (numEncoderThreads > 1)
+  if (mtEncMode)
+  {
     for (i = 0; i < numEncoderThreads; i++)
-      encoders[i].thread[0].Wait();
+    {
+      CEncoderInfo &encoder = encoders[i];
+      WRes wres = encoder.ReadyEvent.Lock();
+      if (wres != 0)
+        return HRESULT_FROM_WIN32(wres);
+      RINOK(encoder.Results[0]);
+    }
+
+    CBenchProgressInfo *bpi = encoders[0].progressInfoSpec[0];
+    bpi->SetStartTime();
+
+    WRes wres = encoderFlusher.StartAndWait();
+    if (status.Res == 0 && wres != 0)
+      return HRESULT_FROM_WIN32(wres);
+  }
+  else
   #endif
+  {
+    RINOK(encoders[0].Encode());
+  }
 
   RINOK(status.Res);
 
@@ -1327,11 +1411,16 @@ static HRESULT MethodBench(
     CEncoderInfo &encoder = encoders[i];
     info.UnpackSize += encoder.kBufferSize;
     info.PackSize += encoder.compressedSize;
+    // printf("\n%7d\n", encoder.compressedSize);
   }
   
   RINOK(callback->SetEncodeResult(info, true));
 
 
+
+
+  // ---------- Decode ----------
+
   status.Res = S_OK;
   status.EncodeMode = false;
 
@@ -1618,21 +1707,21 @@ struct CCrcThreads
 
 #endif
 
-static UInt32 CrcCalc1(const Byte *buf, UInt32 size)
+static UInt32 CrcCalc1(const Byte *buf, size_t size)
 {
   UInt32 crc = CRC_INIT_VAL;;
-  for (UInt32 i = 0; i < size; i++)
+  for (size_t i = 0; i < size; i++)
     crc = CRC_UPDATE_BYTE(crc, buf[i]);
   return CRC_GET_DIGEST(crc);
 }
 
-static void RandGen(Byte *buf, UInt32 size, CBaseRandomGenerator &RG)
+static void RandGen(Byte *buf, size_t size, CBaseRandomGenerator &RG)
 {
-  for (UInt32 i = 0; i < size; i++)
+  for (size_t i = 0; i < size; i++)
     buf[i] = (Byte)RG.GetRnd();
 }
 
-static UInt32 RandGenCrc(Byte *buf, UInt32 size, CBaseRandomGenerator &RG)
+static UInt32 RandGenCrc(Byte *buf, size_t size, CBaseRandomGenerator &RG)
 {
   RandGen(buf, size, RG);
   return CrcCalc1(buf, size);
@@ -1640,14 +1729,15 @@ static UInt32 RandGenCrc(Byte *buf, UInt32 size, CBaseRandomGenerator &RG)
 
 bool CrcInternalTest()
 {
-  CBenchBuffer buffer;
-  const UInt32 kBufferSize0 = (1 << 8);
-  const UInt32 kBufferSize1 = (1 << 10);
-  const UInt32 kCheckSize = (1 << 5);
-  if (!buffer.Alloc(kBufferSize0 + kBufferSize1))
+  CAlignedBuffer buffer;
+  const size_t kBufferSize0 = (1 << 8);
+  const size_t kBufferSize1 = (1 << 10);
+  const unsigned kCheckSize = (1 << 5);
+  buffer.Alloc(kBufferSize0 + kBufferSize1);
+  if (!buffer.IsAllocated())
     return false;
-  Byte *buf = buffer.Buffer;
-  UInt32 i;
+  Byte *buf = (Byte *)buffer;
+  size_t i;
   for (i = 0; i < kBufferSize0; i++)
     buf[i] = (Byte)i;
   UInt32 crc1 = CrcCalc1(buf, kBufferSize0);
@@ -1656,7 +1746,7 @@ bool CrcInternalTest()
   CBaseRandomGenerator RG;
   RandGen(buf + kBufferSize0, kBufferSize1, RG);
   for (i = 0; i < kBufferSize0 + kBufferSize1 - kCheckSize; i++)
-    for (UInt32 j = 0; j < kCheckSize; j++)
+    for (unsigned j = 0; j < kCheckSize; j++)
       if (CrcCalc1(buf + i, j) != CrcCalc(buf + i, j))
         return false;
   return true;
@@ -1920,6 +2010,10 @@ void Add_LargePages_String(AString &s)
   {
     s += " (LP-";
     PrintSize(s, g_LargePageSize);
+    #ifdef MY_CPU_X86_OR_AMD64
+    if (CPU_IsSupported_PageGB())
+      s += "-1G";
+    #endif
     if (!g_LargePagesMode)
       s += "-NA";
     s += ")";
@@ -2238,14 +2332,13 @@ static HRESULT CrcBench(
       methodName, hashID))
     return E_NOTIMPL;
 
-  CBenchBuffer buffer;
+  CAlignedBuffer buffer;
   size_t totalSize = (size_t)bufferSize * numThreads;
   if (totalSize / numThreads != bufferSize)
     return E_OUTOFMEMORY;
-  if (!buffer.Alloc(totalSize))
-    return E_OUTOFMEMORY;
+  ALLOC_WITH_HRESULT(&buffer, totalSize)
 
-  Byte *buf = buffer.Buffer;
+  Byte *buf = (Byte *)buffer;
   CBaseRandomGenerator RG;
   UInt32 bsize = (bufferSize == 0 ? 1 : bufferSize);
   UInt64 numIterations = complexInCommands * 256 / complexity / bsize;
@@ -2793,7 +2886,7 @@ HRESULT Bench(
     bool multiDict)
 {
   if (!CrcInternalTest())
-    return S_FALSE;
+    return E_FAIL;
 
   UInt32 numCPUs = 1;
   UInt64 ramSize = (UInt64)(sizeof(size_t)) << 29;
@@ -2822,7 +2915,7 @@ HRESULT Bench(
 
   COneMethodInfo method;
 
-  CBenchBuffer fileDataBuffer;
+  CAlignedBuffer fileDataBuffer;
 
   {
   unsigned i;
@@ -2847,10 +2940,9 @@ HRESULT Bench(
         return E_FAIL;
       if (len >= ((UInt32)1 << 31) || len == 0)
         return E_INVALIDARG;
-      if (!fileDataBuffer.Alloc((size_t)len))
-        return E_OUTOFMEMORY;
+      ALLOC_WITH_HRESULT(&fileDataBuffer, (size_t)len);
       UInt32 processedSize;
-      file.Read(fileDataBuffer.Buffer, (UInt32)len, processedSize);
+      file.Read((Byte *)fileDataBuffer, (UInt32)len, processedSize);
       if (processedSize != len)
         return E_FAIL;
       if (printCallback)
@@ -3066,7 +3158,7 @@ HRESULT Bench(
         complexInCommands,
         true, numThreadsSpecified,
         method,
-        uncompressedDataSize, fileDataBuffer.Buffer,
+        uncompressedDataSize, (const Byte *)fileDataBuffer,
         kOldLzmaDictBits, printCallback, benchCallback, &benchProps);
   }
 
@@ -3378,9 +3470,9 @@ HRESULT Bench(
       {
         res = TotalBench(EXTERNAL_CODECS_LOC_VARS
             complexInCommands, numThreads,
-            dictIsDefined || fileDataBuffer.Buffer, // forceUnpackSize
-            fileDataBuffer.Buffer ? fileDataBuffer.BufferSize : dict,
-            fileDataBuffer.Buffer,
+            dictIsDefined || fileDataBuffer.IsAllocated(), // forceUnpackSize
+            fileDataBuffer.IsAllocated() ? fileDataBuffer.Size() : dict,
+            (const Byte *)fileDataBuffer,
             printCallback, &callback);
         RINOK(res);
       }
@@ -3470,9 +3562,9 @@ HRESULT Bench(
       }
 
       size_t uncompressedDataSize;
-      if (fileDataBuffer.Buffer)
+      if (fileDataBuffer.IsAllocated())
       {
-        uncompressedDataSize = fileDataBuffer.BufferSize;
+        uncompressedDataSize = fileDataBuffer.Size();
       }
       else
       {
@@ -3486,7 +3578,7 @@ HRESULT Bench(
           complexInCommands,
           true, numThreads,
           method2,
-          uncompressedDataSize, fileDataBuffer.Buffer,
+          uncompressedDataSize, (const Byte *)fileDataBuffer,
           kOldLzmaDictBits, printCallback, &callback, &callback.BenchProps);
       f.NewLine();
       RINOK(res);

CPP/7zip/UI/Console/Console.mak

@@ -1,3 +1,9 @@
+MY_CONSOLE = 1
+
+!IFNDEF UNDER_CE
+CFLAGS = $(CFLAGS) -DWIN_LONG_PATH -D_7ZIP_LARGE_PAGES -DSUPPORT_DEVICE_FILE
+!ENDIF
+
 CONSOLE_OBJS = \
   $O\BenchCon.obj \
   $O\ConsoleClose.obj \
@@ -33,4 +39,5 @@ UI_COMMON_OBJS = \
   $O\UpdatePair.obj \
   $O\UpdateProduce.obj \
 
-#
+C_OBJS = $(C_OBJS) \
+  $O\DllSecur.obj \

CPP/7zip/UI/Console/Main.cpp

@@ -87,7 +87,7 @@ static const char * const kHelpString =
     "a"
 #endif
 #endif
-    " <command> [<switches>...] <archive_name> [<file_names>...]\n"
+    " <command> [<switches>...] <archive_name> [<file_names>...] [@listfile]\n"
     "\n"
     "<Commands>\n"
     "  a : Add files to archive\n"
@@ -103,8 +103,7 @@ static const char * const kHelpString =
     "  x : eXtract files with full paths\n"
     "\n"
     "<Switches>\n"
-    "  -- : Stop switches parsing\n"
-    "  @listfile : set path to listfile that contains file names\n"
+    "  -- : Stop switches and @listfile parsing\n"
     "  -ai[r[-|0]]{@listfile|!wildcard} : Include archives\n"
     "  -ax[r[-|0]]{@listfile|!wildcard} : eXclude archives\n"
     "  -ao{a|s|t|u} : set Overwrite mode\n"

CPP/7zip/UI/Console/MainAr.cpp

@@ -2,6 +2,10 @@
 
 #include "StdAfx.h"
 
+#ifdef _WIN32
+#include "../../../../C/DllSecur.h"
+#endif
+
 #include "../../../Common/MyException.h"
 #include "../../../Common/StdOutStream.h"
 
@@ -63,6 +67,10 @@ int MY_CDECL main
   
   try
   {
+    #ifdef _WIN32
+    My_SetDefaultDllDirectories();
+    #endif
+
     res = Main2(
     #ifndef _WIN32
     numArgs, args

CPP/7zip/UI/Console/makefile

@@ -1,72 +1,64 @@
-PROG = 7z.exe
-MY_CONSOLE = 1
-CFLAGS = $(CFLAGS)  \
-  -DEXTERNAL_CODECS \
-
-!IFNDEF UNDER_CE
-CFLAGS = $(CFLAGS) -DWIN_LONG_PATH -D_7ZIP_LARGE_PAGES -DSUPPORT_DEVICE_FILE
-!ENDIF
-
-COMMON_OBJS = \
-  $O\CommandLineParser.obj \
-  $O\CRC.obj \
-  $O\IntToString.obj \
-  $O\ListFileUtils.obj \
-  $O\NewHandler.obj \
-  $O\StdInStream.obj \
-  $O\StdOutStream.obj \
-  $O\MyString.obj \
-  $O\StringConvert.obj \
-  $O\StringToInt.obj \
-  $O\UTFConvert.obj \
-  $O\MyVector.obj \
-  $O\Wildcard.obj \
-  $O\ResourceString.obj \
-  
-
-WIN_OBJS = \
-  $O\DLL.obj \
-  $O\ErrorMsg.obj \
-  $O\FileDir.obj \
-  $O\FileFind.obj \
-  $O\FileIO.obj \
-  $O\FileLink.obj \
-  $O\FileName.obj \
-  $O\FileSystem.obj \
-  $O\MemoryLock.obj \
-  $O\PropVariant.obj \
-  $O\PropVariantConv.obj \
-  $O\Registry.obj \
-  $O\System.obj \
-  $O\TimeUtils.obj \
-  $O\LoadCodecs.obj \
-
-7ZIP_COMMON_OBJS = \
-  $O\CreateCoder.obj \
-  $O\FilePathAutoRename.obj \
-  $O\FileStreams.obj \
-  $O\FilterCoder.obj \
-  $O\LimitedStreams.obj \
-  $O\MethodProps.obj \
-  $O\ProgressUtils.obj \
-  $O\PropId.obj \
-  $O\StreamObjects.obj \
-  $O\StreamUtils.obj \
-  $O\UniqBlocks.obj \
-
-AR_COMMON_OBJS = \
-  $O\OutStreamWithCRC.obj \
-
-COMPRESS_OBJS = \
-  $O\CopyCoder.obj \
-
-C_OBJS = \
-  $O\Alloc.obj \
-  $O\CpuArch.obj \
-  $O\Sort.obj \
-  $O\Threads.obj \
-
-!include "../../Crc.mak"
-!include "Console.mak"
-
-!include "../../7zip.mak"
+PROG = 7z.exe
+CFLAGS = $(CFLAGS)  \
+  -DEXTERNAL_CODECS \
+
+COMMON_OBJS = \
+  $O\CommandLineParser.obj \
+  $O\CRC.obj \
+  $O\IntToString.obj \
+  $O\ListFileUtils.obj \
+  $O\NewHandler.obj \
+  $O\StdInStream.obj \
+  $O\StdOutStream.obj \
+  $O\MyString.obj \
+  $O\StringConvert.obj \
+  $O\StringToInt.obj \
+  $O\UTFConvert.obj \
+  $O\MyVector.obj \
+  $O\Wildcard.obj \
+
+WIN_OBJS = \
+  $O\DLL.obj \
+  $O\ErrorMsg.obj \
+  $O\FileDir.obj \
+  $O\FileFind.obj \
+  $O\FileIO.obj \
+  $O\FileLink.obj \
+  $O\FileName.obj \
+  $O\FileSystem.obj \
+  $O\MemoryLock.obj \
+  $O\PropVariant.obj \
+  $O\PropVariantConv.obj \
+  $O\Registry.obj \
+  $O\System.obj \
+  $O\TimeUtils.obj \
+
+7ZIP_COMMON_OBJS = \
+  $O\CreateCoder.obj \
+  $O\FilePathAutoRename.obj \
+  $O\FileStreams.obj \
+  $O\FilterCoder.obj \
+  $O\LimitedStreams.obj \
+  $O\MethodProps.obj \
+  $O\ProgressUtils.obj \
+  $O\PropId.obj \
+  $O\StreamObjects.obj \
+  $O\StreamUtils.obj \
+  $O\UniqBlocks.obj \
+
+AR_COMMON_OBJS = \
+  $O\OutStreamWithCRC.obj \
+
+COMPRESS_OBJS = \
+  $O\CopyCoder.obj \
+
+C_OBJS = $(C_OBJS) \
+  $O\Alloc.obj \
+  $O\CpuArch.obj \
+  $O\Sort.obj \
+  $O\Threads.obj \
+
+!include "../../Crc.mak"
+!include "Console.mak"
+
+!include "../../7zip.mak"

CPP/7zip/UI/Explorer/ContextMenu.cpp

@@ -120,7 +120,11 @@ HRESULT CZipContextMenu::InitContextMenu(const wchar_t * /* folder */, const wch
   _isMenuForFM = true;
   _fileNames.Clear();
   for (UInt32 i = 0; i < numFiles; i++)
+  {
+    // MessageBoxW(0, names[i], NULL, 0);
+    // OutputDebugStringW(names[i]);
     _fileNames.Add(names[i]);
+  }
   _dropMode = false;
   return S_OK;
 }
@@ -423,6 +427,13 @@ STDMETHODIMP CZipContextMenu::QueryContextMenu(HMENU hMenu, UINT indexMenu,
 {
   // OutputDebugStringA("QueryContextMenu");
 
+  /*
+  for (UInt32 i = 0; i < _fileNames.Size(); i++)
+  {
+    OutputDebugStringW(_fileNames[i]);
+  }
+  */
+
   LoadLangOneTime();
   if (_fileNames.Size() == 0)
     return E_FAIL;

CPP/7zip/UI/Explorer/Explorer.def

@@ -1,9 +1,9 @@
-; 7-zip.def
-
-LIBRARY "7-zip"
-
-EXPORTS
-  DllCanUnloadNow PRIVATE
-  DllGetClassObject PRIVATE
-  DllRegisterServer PRIVATE
-  DllUnregisterServer PRIVATE
+; 7-zip.def
+
+LIBRARY "7-zip"
+
+EXPORTS
+  DllCanUnloadNow PRIVATE
+  DllGetClassObject PRIVATE
+  DllRegisterServer PRIVATE
+  DllUnregisterServer PRIVATE

CPP/7zip/UI/Explorer/makefile

@@ -1,73 +1,74 @@
-PROG = 7-zip.dll
-DEF_FILE = Explorer.def
-CFLAGS = $(CFLAGS) \
-  -DLANG \
-
-!IFDEF UNDER_CE
-LIBS = $(LIBS) Commctrl.lib
-!ELSE
-LIBS = $(LIBS) htmlhelp.lib comdlg32.lib Mpr.lib Gdi32.lib
-CFLAGS = $(CFLAGS) -DWIN_LONG_PATH
-!ENDIF
-
-EXPLORER_OBJS = \
-  $O\DllExportsExplorer.obj \
-  $O\ContextMenu.obj \
-  $O\MyMessages.obj \
-
-COMMON_OBJS = \
-  $O\IntToString.obj \
-  $O\Lang.obj \
-  $O\MyString.obj \
-  $O\MyVector.obj \
-  $O\NewHandler.obj \
-  $O\Random.obj \
-  $O\StringConvert.obj \
-  $O\StringToInt.obj \
-  $O\UTFConvert.obj \
-  $O\Wildcard.obj \
-
-WIN_OBJS = \
-  $O\DLL.obj \
-  $O\ErrorMsg.obj \
-  $O\FileDir.obj \
-  $O\FileFind.obj \
-  $O\FileIO.obj \
-  $O\FileName.obj \
-  $O\MemoryLock.obj \
-  $O\Menu.obj \
-  $O\ProcessUtils.obj \
-  $O\Registry.obj \
-  $O\ResourceString.obj \
-  $O\Shell.obj \
-  $O\Synchronization.obj \
-  $O\Window.obj \
-
-!IFDEF UNDER_CE
-
-WIN_OBJS = $(WIN_OBJS) \
-  $O\CommonDialog.obj \
-
-!ENDIF
-
-WIN_CTRL_OBJS = \
-  $O\Dialog.obj \
-  $O\ListView.obj \
-
-UI_COMMON_OBJS = \
-  $O\ArchiveName.obj \
-  $O\CompressCall.obj \
-  $O\ExtractingFilePath.obj \
-  $O\ZipRegistry.obj \
-
-FM_OBJS = \
-  $O\FormatUtils.obj \
-  $O\HelpUtils.obj \
-  $O\LangUtils.obj \
-  $O\ProgramLocation.obj \
-  $O\RegistryUtils.obj \
-
-C_OBJS = \
-  $O\Threads.obj \
-
-!include "../../7zip.mak"
+PROG = 7-zip.dll
+DEF_FILE = Explorer.def
+CFLAGS = $(CFLAGS) \
+  -DLANG \
+
+!IFDEF UNDER_CE
+LIBS = $(LIBS) Commctrl.lib
+!ELSE
+LIBS = $(LIBS) htmlhelp.lib comdlg32.lib Mpr.lib Gdi32.lib
+CFLAGS = $(CFLAGS) -DWIN_LONG_PATH
+!ENDIF
+
+EXPLORER_OBJS = \
+  $O\DllExportsExplorer.obj \
+  $O\ContextMenu.obj \
+  $O\MyMessages.obj \
+
+COMMON_OBJS = \
+  $O\IntToString.obj \
+  $O\Lang.obj \
+  $O\MyString.obj \
+  $O\MyVector.obj \
+  $O\NewHandler.obj \
+  $O\Random.obj \
+  $O\StringConvert.obj \
+  $O\StringToInt.obj \
+  $O\UTFConvert.obj \
+  $O\Wildcard.obj \
+
+WIN_OBJS = \
+  $O\DLL.obj \
+  $O\ErrorMsg.obj \
+  $O\FileDir.obj \
+  $O\FileFind.obj \
+  $O\FileIO.obj \
+  $O\FileName.obj \
+  $O\MemoryLock.obj \
+  $O\Menu.obj \
+  $O\ProcessUtils.obj \
+  $O\Registry.obj \
+  $O\ResourceString.obj \
+  $O\Shell.obj \
+  $O\Synchronization.obj \
+  $O\Window.obj \
+
+!IFDEF UNDER_CE
+
+WIN_OBJS = $(WIN_OBJS) \
+  $O\CommonDialog.obj \
+
+!ENDIF
+
+WIN_CTRL_OBJS = \
+  $O\Dialog.obj \
+  $O\ListView.obj \
+
+UI_COMMON_OBJS = \
+  $O\ArchiveName.obj \
+  $O\CompressCall.obj \
+  $O\ExtractingFilePath.obj \
+  $O\ZipRegistry.obj \
+
+FM_OBJS = \
+  $O\FormatUtils.obj \
+  $O\HelpUtils.obj \
+  $O\LangUtils.obj \
+  $O\ProgramLocation.obj \
+  $O\RegistryUtils.obj \
+
+C_OBJS = \
+  $O\CpuArch.obj \
+  $O\Threads.obj \
+
+!include "../../7zip.mak"

CPP/7zip/UI/Far/Far.def

@@ -1,35 +1,35 @@
-; 7-ZipFar.def : Declares the module parameters for the DLL.
-
-LIBRARY      "7-ZipFar"
-
-EXPORTS
-  ExitFAR
-  SetStartupInfo
-  OpenPlugin
-  OpenFilePlugin
-  ClosePlugin
-  GetFindData
-  FreeFindData
-  SetDirectory
-  GetPluginInfo
-  Configure
-  GetOpenPluginInfo
-  GetFiles
-  PutFiles
-  DeleteFiles
-  ProcessKey
-
-  ;SetStartupInfoW
-  ;OpenPluginW
-  ;OpenFilePluginW
-  ;ClosePluginW
-  ;GetFindDataW
-  ;FreeFindDataW
-  ;SetDirectoryW
-  ;GetPluginInfoW
-  ;ConfigureW
-  ;GetOpenPluginInfoW
-  ;GetFilesW
-  ;PutFilesW
-  ;DeleteFilesW
-  ;ProcessKeyW
+; 7-ZipFar.def : Declares the module parameters for the DLL.
+
+LIBRARY      "7-ZipFar"
+
+EXPORTS
+  ExitFAR
+  SetStartupInfo
+  OpenPlugin
+  OpenFilePlugin
+  ClosePlugin
+  GetFindData
+  FreeFindData
+  SetDirectory
+  GetPluginInfo
+  Configure
+  GetOpenPluginInfo
+  GetFiles
+  PutFiles
+  DeleteFiles
+  ProcessKey
+
+  ;SetStartupInfoW
+  ;OpenPluginW
+  ;OpenFilePluginW
+  ;ClosePluginW
+  ;GetFindDataW
+  ;FreeFindDataW
+  ;SetDirectoryW
+  ;GetPluginInfoW
+  ;ConfigureW
+  ;GetOpenPluginInfoW
+  ;GetFilesW
+  ;PutFilesW
+  ;DeleteFilesW
+  ;ProcessKeyW

CPP/7zip/UI/FileManager/FM.cpp

@@ -7,6 +7,9 @@
 #include <shlwapi.h>
 
 #include "../../../../C/Alloc.h"
+#ifdef _WIN32
+#include "../../../../C/DllSecur.h"
+#endif
 
 #include "../../../Common/StringConvert.h"
 #include "../../../Common/StringToInt.h"
@@ -660,6 +663,9 @@ int WINAPI WinMain(HINSTANCE hInstance, HINSTANCE /* hPrevInstance */,
   {
     try
     {
+      #ifdef _WIN32
+      My_SetDefaultDllDirectories();
+      #endif
       return WinMain2(nCmdShow);
     }
     catch (...)

CPP/7zip/UI/FileManager/FM.mak

@@ -1,3 +1,16 @@
+CFLAGS = $(CFLAGS) \
+  -DLANG \
+  -DNEW_FOLDER_INTERFACE \
+
+!IFDEF UNDER_CE
+LIBS = $(LIBS) ceshell.lib Commctrl.lib
+!ELSE
+LIBS = $(LIBS) comctl32.lib htmlhelp.lib comdlg32.lib Mpr.lib Gdi32.lib
+CFLAGS = $(CFLAGS) -DWIN_LONG_PATH -DSUPPORT_DEVICE_FILE
+LFLAGS = $(LFLAGS) /DELAYLOAD:mpr.dll 
+LIBS = $(LIBS) delayimp.lib 
+!ENDIF
+
 FM_OBJS = \
   $O\App.obj \
   $O\BrowseDialog.obj \
@@ -73,6 +86,9 @@ WIN_OBJS = $(WIN_OBJS) \
 
 !ENDIF
 
+C_OBJS = $(C_OBJS) \
+  $O\DllSecur.obj \
+
 AGENT_OBJS = \
   $O\Agent.obj \
   $O\AgentOut.obj \

CPP/7zip/UI/FileManager/FSFolder.cpp

@@ -532,9 +532,8 @@ STDMETHODIMP CFSFolder::GetNumRawProps(UInt32 *numProps)
   return S_OK;
 }
 
-STDMETHODIMP CFSFolder::GetRawPropInfo(UInt32 index, BSTR *name, PROPID *propID)
+STDMETHODIMP CFSFolder::GetRawPropInfo(UInt32 /* index */, BSTR *name, PROPID *propID)
 {
-  index = index;
   *name = NULL;
   *propID = kpidNtReparse;
   return S_OK;

CPP/7zip/UI/FileManager/FSFolderCopy.cpp

@@ -161,8 +161,6 @@ static DWORD CALLBACK CopyProgressRoutine(
   LPVOID lpData                         // from CopyFileEx
 )
 {
-  TotalFileSize = TotalFileSize;
-  // TotalBytesTransferred = TotalBytesTransferred;
   // StreamSize = StreamSize;
   // StreamBytesTransferred = StreamBytesTransferred;
   // dwStreamNumber = dwStreamNumber;

CPP/7zip/UI/FileManager/makefile

@@ -1,110 +1,102 @@
-PROG = 7zFM.exe
-CFLAGS = $(CFLAGS) \
-  -DLANG \
-  -DNEW_FOLDER_INTERFACE \
-  -DEXTERNAL_CODECS \
-
-!IFDEF UNDER_CE
-LIBS = $(LIBS) ceshell.lib Commctrl.lib
-!ELSE
-LIBS = $(LIBS) comctl32.lib htmlhelp.lib comdlg32.lib Mpr.lib Gdi32.lib
-CFLAGS = $(CFLAGS) -DWIN_LONG_PATH -DSUPPORT_DEVICE_FILE
-!ENDIF
-
-!include "FM.mak"
-
-COMMON_OBJS = \
-  $O\IntToString.obj \
-  $O\Lang.obj \
-  $O\MyString.obj \
-  $O\MyVector.obj \
-  $O\NewHandler.obj \
-  $O\Random.obj \
-  $O\StringConvert.obj \
-  $O\StringToInt.obj \
-  $O\UTFConvert.obj \
-  $O\Wildcard.obj
-
-WIN_OBJS = $(WIN_OBJS) \
-  $O\Clipboard.obj \
-  $O\CommonDialog.obj \
-  $O\DLL.obj \
-  $O\ErrorMsg.obj \
-  $O\FileDir.obj \
-  $O\FileFind.obj \
-  $O\FileIO.obj \
-  $O\FileLink.obj \
-  $O\FileName.obj \
-  $O\MemoryGlobal.obj \
-  $O\MemoryLock.obj \
-  $O\Menu.obj \
-  $O\ProcessUtils.obj \
-  $O\PropVariant.obj \
-  $O\PropVariantConv.obj \
-  $O\Registry.obj \
-  $O\ResourceString.obj \
-  $O\Shell.obj \
-  $O\Synchronization.obj \
-  $O\System.obj \
-  $O\TimeUtils.obj \
-  $O\Window.obj \
-
-
-WIN_CTRL_OBJS = \
-  $O\ComboBox.obj \
-  $O\Dialog.obj \
-  $O\ListView.obj \
-  $O\PropertyPage.obj \
-  $O\Window2.obj \
-
-7ZIP_COMMON_OBJS = \
-  $O\CreateCoder.obj \
-  $O\FilePathAutoRename.obj \
-  $O\FileStreams.obj \
-  $O\FilterCoder.obj \
-  $O\LimitedStreams.obj \
-  $O\MethodProps.obj \
-  $O\ProgressUtils.obj \
-  $O\PropId.obj \
-  $O\StreamObjects.obj \
-  $O\StreamUtils.obj \
-  $O\UniqBlocks.obj \
-
-UI_COMMON_OBJS = \
-  $O\ArchiveExtractCallback.obj \
-  $O\ArchiveName.obj \
-  $O\ArchiveOpenCallback.obj \
-  $O\CompressCall.obj \
-  $O\DefaultName.obj \
-  $O\EnumDirItems.obj \
-  $O\ExtractingFilePath.obj \
-  $O\HashCalc.obj \
-  $O\LoadCodecs.obj \
-  $O\OpenArchive.obj \
-  $O\PropIDUtils.obj \
-  $O\SetProperties.obj \
-  $O\SortUtils.obj \
-  $O\UpdateAction.obj \
-  $O\UpdateCallback.obj \
-  $O\UpdatePair.obj \
-  $O\UpdateProduce.obj \
-  $O\WorkDir.obj \
-  $O\ZipRegistry.obj \
-
-EXPLORER_OBJS = \
-  $O\ContextMenu.obj \
-  $O\RegistryContextMenu.obj \
-
-GUI_OBJS = \
-  $O\HashGUI.obj \
-  $O\UpdateCallbackGUI2.obj \
-
-COMPRESS_OBJS = \
-  $O\CopyCoder.obj \
-
-C_OBJS = \
-  $O\Alloc.obj \
-  $O\Sort.obj \
-  $O\Threads.obj \
-
-!include "../../7zip.mak"
+PROG = 7zFM.exe
+CFLAGS = $(CFLAGS) \
+  -DEXTERNAL_CODECS \
+
+!include "FM.mak"
+
+COMMON_OBJS = \
+  $O\IntToString.obj \
+  $O\Lang.obj \
+  $O\MyString.obj \
+  $O\MyVector.obj \
+  $O\NewHandler.obj \
+  $O\Random.obj \
+  $O\StringConvert.obj \
+  $O\StringToInt.obj \
+  $O\UTFConvert.obj \
+  $O\Wildcard.obj \
+
+WIN_OBJS = $(WIN_OBJS) \
+  $O\Clipboard.obj \
+  $O\CommonDialog.obj \
+  $O\DLL.obj \
+  $O\ErrorMsg.obj \
+  $O\FileDir.obj \
+  $O\FileFind.obj \
+  $O\FileIO.obj \
+  $O\FileLink.obj \
+  $O\FileName.obj \
+  $O\MemoryGlobal.obj \
+  $O\MemoryLock.obj \
+  $O\Menu.obj \
+  $O\ProcessUtils.obj \
+  $O\PropVariant.obj \
+  $O\PropVariantConv.obj \
+  $O\Registry.obj \
+  $O\ResourceString.obj \
+  $O\Shell.obj \
+  $O\Synchronization.obj \
+  $O\System.obj \
+  $O\TimeUtils.obj \
+  $O\Window.obj \
+
+
+WIN_CTRL_OBJS = \
+  $O\ComboBox.obj \
+  $O\Dialog.obj \
+  $O\ListView.obj \
+  $O\PropertyPage.obj \
+  $O\Window2.obj \
+
+7ZIP_COMMON_OBJS = \
+  $O\CreateCoder.obj \
+  $O\FilePathAutoRename.obj \
+  $O\FileStreams.obj \
+  $O\FilterCoder.obj \
+  $O\LimitedStreams.obj \
+  $O\MethodProps.obj \
+  $O\ProgressUtils.obj \
+  $O\PropId.obj \
+  $O\StreamObjects.obj \
+  $O\StreamUtils.obj \
+  $O\UniqBlocks.obj \
+
+UI_COMMON_OBJS = \
+  $O\ArchiveExtractCallback.obj \
+  $O\ArchiveName.obj \
+  $O\ArchiveOpenCallback.obj \
+  $O\CompressCall.obj \
+  $O\DefaultName.obj \
+  $O\EnumDirItems.obj \
+  $O\ExtractingFilePath.obj \
+  $O\HashCalc.obj \
+  $O\LoadCodecs.obj \
+  $O\OpenArchive.obj \
+  $O\PropIDUtils.obj \
+  $O\SetProperties.obj \
+  $O\SortUtils.obj \
+  $O\UpdateAction.obj \
+  $O\UpdateCallback.obj \
+  $O\UpdatePair.obj \
+  $O\UpdateProduce.obj \
+  $O\WorkDir.obj \
+  $O\ZipRegistry.obj \
+
+EXPLORER_OBJS = \
+  $O\ContextMenu.obj \
+  $O\RegistryContextMenu.obj \
+
+GUI_OBJS = \
+  $O\HashGUI.obj \
+  $O\UpdateCallbackGUI2.obj \
+
+COMPRESS_OBJS = \
+  $O\CopyCoder.obj \
+
+C_OBJS = $(C_OBJS) \
+  $O\Alloc.obj \
+  $O\CpuArch.obj \
+  $O\Sort.obj \
+  $O\Threads.obj \
+
+!include "../../7zip.mak"

CPP/7zip/UI/GUI/GUI.cpp

@@ -2,6 +2,10 @@
 
 #include "StdAfx.h"
 
+#ifdef _WIN32
+#include "../../../../C/DllSecur.h"
+#endif
+
 #include "../../../Common/MyWindows.h"
 
 #include <shlwapi.h>
@@ -372,6 +376,10 @@ int APIENTRY WinMain(HINSTANCE  hInstance, HINSTANCE /* hPrevInstance */,
   // setlocale(LC_COLLATE, ".ACP");
   try
   {
+    #ifdef _WIN32
+    My_SetDefaultDllDirectories();
+    #endif
+
     return Main2();
   }
   catch(const CNewException &)

CPP/7zip/UI/GUI/HashGUI.cpp

@@ -20,337 +20,334 @@
 
 using namespace NWindows;
 
-
-
-class CHashCallbackGUI: public CProgressThreadVirt, public IHashCallbackUI
+class CHashCallbackGUI : public CProgressThreadVirt, public IHashCallbackUI
 {
-  UInt64 NumFiles;
-  bool _curIsFolder;
-  UString FirstFileName;
-  // UString MainPath;
+    UInt64 NumFiles;
+    bool _curIsFolder;
+    UString FirstFileName;
+    // UString MainPath;
 
-  CPropNameValPairs PropNameValPairs;
+    CPropNameValPairs PropNameValPairs;
 
-  HRESULT ProcessVirt();
-  virtual void ProcessWasFinished_GuiVirt();
+    HRESULT ProcessVirt();
+    virtual void ProcessWasFinished_GuiVirt();
 
-public:
-  const NWildcard::CCensor *censor;
-  const CHashOptions *options;
+  public:
+    const NWildcard::CCensor *censor;
+    const CHashOptions *options;
 
-  DECL_EXTERNAL_CODECS_LOC_VARS2;
+    DECL_EXTERNAL_CODECS_LOC_VARS2;
 
-  CHashCallbackGUI() {}
-  ~CHashCallbackGUI() { }
+    CHashCallbackGUI() {}
+    ~CHashCallbackGUI() {}
 
-  INTERFACE_IHashCallbackUI(;)
+    INTERFACE_IHashCallbackUI(;)
 
-  void AddErrorMessage(DWORD systemError, const wchar_t *name)
-  {
-    Sync.AddError_Code_Name(systemError, name);
-  }
+        void AddErrorMessage(DWORD systemError, const wchar_t *name)
+    {
+        Sync.AddError_Code_Name(systemError, name);
+    }
 };
 
-
 void AddValuePair(CPropNameValPairs &pairs, UINT resourceID, UInt64 value)
 {
-  CProperty &pair = pairs.AddNew();
-  AddLangString(pair.Name, resourceID);
-  char sz[32];
-  ConvertUInt64ToString(value, sz);
-  pair.Value = sz;
+    CProperty &pair = pairs.AddNew();
+    AddLangString(pair.Name, resourceID);
+    char sz[32];
+    ConvertUInt64ToString(value, sz);
+    pair.Value = sz;
 }
 
-
 void AddSizeValue(UString &s, UInt64 value)
 {
-  {
-    wchar_t sz[32];
-    ConvertUInt64ToString(value, sz);
-    s += MyFormatNew(IDS_FILE_SIZE, sz);
-  }
-  if (value >= (1 << 10))
-  {
-    char c;
-          if (value >= ((UInt64)10 << 30)) { value >>= 30; c = 'G'; }
-    else  if (value >=         (10 << 20)) { value >>= 20; c = 'M'; }
-    else                                   { value >>= 10; c = 'K'; }
-    char sz[32];
-    ConvertUInt64ToString(value, sz);
-    s += " (";
-    s += sz;
-    s += " ";
-    s += (wchar_t)c;
-    s += "iB)";
-  }
+    {
+        wchar_t sz[32];
+        ConvertUInt64ToString(value, sz);
+        s += MyFormatNew(IDS_FILE_SIZE, sz);
+    }
+    if (value >= (1 << 10))
+    {
+        char c;
+        if (value >= ((UInt64)10 << 30))
+        {
+            value >>= 30;
+            c = 'G';
+        }
+        else if (value >= (10 << 20))
+        {
+            value >>= 20;
+            c = 'M';
+        }
+        else
+        {
+            value >>= 10;
+            c = 'K';
+        }
+        char sz[32];
+        ConvertUInt64ToString(value, sz);
+        s += " (";
+        s += sz;
+        s += " ";
+        s += (wchar_t)c;
+        s += "iB)";
+    }
 }
 
 void AddSizeValuePair(CPropNameValPairs &pairs, UINT resourceID, UInt64 value)
 {
-  CProperty &pair = pairs.AddNew();
-  LangString(resourceID, pair.Name);
-  AddSizeValue(pair.Value, value);
+    CProperty &pair = pairs.AddNew();
+    LangString(resourceID, pair.Name);
+    AddSizeValue(pair.Value, value);
 }
 
-
 HRESULT CHashCallbackGUI::StartScanning()
 {
-  CProgressSync &sync = Sync;
-  sync.Set_Status(LangString(IDS_SCANNING));
-  return CheckBreak();
+    CProgressSync &sync = Sync;
+    sync.Set_Status(LangString(IDS_SCANNING));
+    return CheckBreak();
 }
 
 HRESULT CHashCallbackGUI::ScanProgress(const CDirItemsStat &st, const FString &path, bool isDir)
 {
-  return Sync.ScanProgress(st.NumFiles, st.GetTotalBytes(), path, isDir);
+    return Sync.ScanProgress(st.NumFiles, st.GetTotalBytes(), path, isDir);
 }
 
 HRESULT CHashCallbackGUI::ScanError(const FString &path, DWORD systemError)
 {
-  AddErrorMessage(systemError, fs2us(path));
-  return CheckBreak();
+    AddErrorMessage(systemError, fs2us(path));
+    return CheckBreak();
 }
 
 HRESULT CHashCallbackGUI::FinishScanning(const CDirItemsStat &st)
 {
-  return ScanProgress(st, FString(), false);
+    return ScanProgress(st, FString(), false);
 }
 
 HRESULT CHashCallbackGUI::CheckBreak()
 {
-  return Sync.CheckStop();
+    return Sync.CheckStop();
 }
 
 HRESULT CHashCallbackGUI::SetNumFiles(UInt64 numFiles)
 {
-  CProgressSync &sync = Sync;
-  sync.Set_NumFilesTotal(numFiles);
-  return CheckBreak();
+    CProgressSync &sync = Sync;
+    sync.Set_NumFilesTotal(numFiles);
+    return CheckBreak();
 }
 
 HRESULT CHashCallbackGUI::SetTotal(UInt64 size)
 {
-  CProgressSync &sync = Sync;
-  sync.Set_NumBytesTotal(size);
-  return CheckBreak();
+    CProgressSync &sync = Sync;
+    sync.Set_NumBytesTotal(size);
+    return CheckBreak();
 }
 
 HRESULT CHashCallbackGUI::SetCompleted(const UInt64 *completed)
 {
-  return Sync.Set_NumBytesCur(completed);
+    return Sync.Set_NumBytesCur(completed);
 }
 
 HRESULT CHashCallbackGUI::BeforeFirstFile(const CHashBundle & /* hb */)
 {
-  return S_OK;
+    return S_OK;
 }
 
 HRESULT CHashCallbackGUI::GetStream(const wchar_t *name, bool isFolder)
 {
-  if (NumFiles == 0)
-    FirstFileName = name;
-  _curIsFolder = isFolder;
-  CProgressSync &sync = Sync;
-  sync.Set_FilePath(name, isFolder);
-  return CheckBreak();
+    if (NumFiles == 0)
+        FirstFileName = name;
+    _curIsFolder = isFolder;
+    CProgressSync &sync = Sync;
+    sync.Set_FilePath(name, isFolder);
+    return CheckBreak();
 }
 
 HRESULT CHashCallbackGUI::OpenFileError(const FString &path, DWORD systemError)
 {
-  // if (systemError == ERROR_SHARING_VIOLATION)
-  {
-    AddErrorMessage(systemError, fs2us(path));
-    return S_FALSE;
-  }
-  // return systemError;
+    // if (systemError == ERROR_SHARING_VIOLATION)
+    {
+        AddErrorMessage(systemError, fs2us(path));
+        return S_FALSE;
+    }
+    // return systemError;
 }
 
 HRESULT CHashCallbackGUI::SetOperationResult(UInt64 /* fileSize */, const CHashBundle & /* hb */, bool /* showHash */)
 {
-  CProgressSync &sync = Sync;
-  if (!_curIsFolder)
-    NumFiles++;
-  sync.Set_NumFilesCur(NumFiles);
-  return CheckBreak();
+    CProgressSync &sync = Sync;
+    if (!_curIsFolder)
+        NumFiles++;
+    sync.Set_NumFilesCur(NumFiles);
+    return CheckBreak();
 }
 
 static void AddHashString(CProperty &s, const CHasherState &h, unsigned digestIndex)
 {
-  char temp[k_HashCalc_DigestSize_Max * 2 + 4];
-  AddHashHexToString(temp, h.Digests[digestIndex], h.DigestSize);
-  s.Value = temp;
+    char temp[k_HashCalc_DigestSize_Max * 2 + 4];
+    AddHashHexToString(temp, h.Digests[digestIndex], h.DigestSize);
+    s.Value = temp;
 }
 
 static void AddHashResString(CPropNameValPairs &s, const CHasherState &h, unsigned digestIndex, UInt32 resID)
 {
-  CProperty &pair = s.AddNew();
-  UString &s2 = pair.Name;
-  LangString(resID, s2);
-  UString name (h.Name);
-  s2.Replace(L"CRC", name);
-  s2.Replace(L":", L"");
-  AddHashString(pair, h, digestIndex);
+    CProperty &pair = s.AddNew();
+    UString &s2 = pair.Name;
+    LangString(resID, s2);
+    UString name(h.Name);
+    s2.Replace(L"CRC", name);
+    s2.Replace(L":", L"");
+    AddHashString(pair, h, digestIndex);
 }
 
-
 void AddHashBundleRes(CPropNameValPairs &s, const CHashBundle &hb)
 {
-  if (hb.NumErrors != 0)
-    AddValuePair(s, IDS_PROP_NUM_ERRORS, hb.NumErrors);
+    if (hb.NumErrors != 0)
+        AddValuePair(s, IDS_PROP_NUM_ERRORS, hb.NumErrors);
 
-  if (hb.NumFiles == 1 && hb.NumDirs == 0 && !hb.FirstFileName.IsEmpty())
-  {
-    CProperty &pair = s.AddNew();
-    LangString(IDS_PROP_NAME, pair.Name);
-    pair.Value = hb.FirstFileName;
-  }
-  else
-  {
-    if (!hb.MainName.IsEmpty())
+    if (hb.NumFiles == 1 && hb.NumDirs == 0 && !hb.FirstFileName.IsEmpty())
     {
-      CProperty &pair = s.AddNew();
-      LangString(IDS_PROP_NAME, pair.Name);
-      pair.Value = hb.MainName;
-    }
-    if (hb.NumDirs != 0)
-      AddValuePair(s, IDS_PROP_FOLDERS, hb.NumDirs);
-    AddValuePair(s, IDS_PROP_FILES, hb.NumFiles);
-  }
-
-  AddSizeValuePair(s, IDS_PROP_SIZE, hb.FilesSize);
-
-  if (hb.NumAltStreams != 0)
-  {
-    AddValuePair(s, IDS_PROP_NUM_ALT_STREAMS, hb.NumAltStreams);
-    AddSizeValuePair(s, IDS_PROP_ALT_STREAMS_SIZE, hb.AltStreamsSize);
-  }
-
-  FOR_VECTOR (i, hb.Hashers)
-  {
-    const CHasherState &h = hb.Hashers[i];
-    if (hb.NumFiles == 1 && hb.NumDirs == 0)
-    {
-      CProperty &pair = s.AddNew();
-      pair.Name += h.Name;
-      AddHashString(pair, h, k_HashCalc_Index_DataSum);
+        CProperty &pair = s.AddNew();
+        LangString(IDS_PROP_NAME, pair.Name);
+        pair.Value = hb.FirstFileName;
     }
     else
     {
-      AddHashResString(s, h, k_HashCalc_Index_DataSum, IDS_CHECKSUM_CRC_DATA);
-      AddHashResString(s, h, k_HashCalc_Index_NamesSum, IDS_CHECKSUM_CRC_DATA_NAMES);
+        if (!hb.MainName.IsEmpty())
+        {
+            CProperty &pair = s.AddNew();
+            LangString(IDS_PROP_NAME, pair.Name);
+            pair.Value = hb.MainName;
+        }
+        if (hb.NumDirs != 0)
+            AddValuePair(s, IDS_PROP_FOLDERS, hb.NumDirs);
+        AddValuePair(s, IDS_PROP_FILES, hb.NumFiles);
     }
+
+    AddSizeValuePair(s, IDS_PROP_SIZE, hb.FilesSize);
+
     if (hb.NumAltStreams != 0)
     {
-      AddHashResString(s, h, k_HashCalc_Index_StreamsSum, IDS_CHECKSUM_CRC_STREAMS_NAMES);
+        AddValuePair(s, IDS_PROP_NUM_ALT_STREAMS, hb.NumAltStreams);
+        AddSizeValuePair(s, IDS_PROP_ALT_STREAMS_SIZE, hb.AltStreamsSize);
     }
-  }
-}
 
+    FOR_VECTOR(i, hb.Hashers)
+    {
+        const CHasherState &h = hb.Hashers[i];
+        if (hb.NumFiles == 1 && hb.NumDirs == 0)
+        {
+            CProperty &pair = s.AddNew();
+            pair.Name += h.Name;
+            AddHashString(pair, h, k_HashCalc_Index_DataSum);
+        }
+        else
+        {
+            AddHashResString(s, h, k_HashCalc_Index_DataSum, IDS_CHECKSUM_CRC_DATA);
+            AddHashResString(s, h, k_HashCalc_Index_NamesSum, IDS_CHECKSUM_CRC_DATA_NAMES);
+        }
+        if (hb.NumAltStreams != 0)
+        {
+            AddHashResString(s, h, k_HashCalc_Index_StreamsSum, IDS_CHECKSUM_CRC_STREAMS_NAMES);
+        }
+    }
+}
 
 void AddHashBundleRes(UString &s, const CHashBundle &hb)
 {
-  CPropNameValPairs pairs;
-  AddHashBundleRes(pairs, hb);
-  
-  FOR_VECTOR (i, pairs)
-  {
-    const CProperty &pair = pairs[i];
-    s += pair.Name;
-    s += ": ";
-    s += pair.Value;
-    s.Add_LF();
-  }
+    CPropNameValPairs pairs;
+    AddHashBundleRes(pairs, hb);
 
-  if (hb.NumErrors == 0 && hb.Hashers.IsEmpty())
-  {
-    s.Add_LF();
-    AddLangString(s, IDS_MESSAGE_NO_ERRORS);
-    s.Add_LF();
-  }
+    FOR_VECTOR(i, pairs)
+    {
+        const CProperty &pair = pairs[i];
+        s += pair.Name;
+        s += ": ";
+        s += pair.Value;
+        s.Add_LF();
+    }
+
+    if (hb.NumErrors == 0 && hb.Hashers.IsEmpty())
+    {
+        s.Add_LF();
+        AddLangString(s, IDS_MESSAGE_NO_ERRORS);
+        s.Add_LF();
+    }
 }
 
-
 HRESULT CHashCallbackGUI::AfterLastFile(CHashBundle &hb)
 {
-  AddHashBundleRes(PropNameValPairs, hb, FirstFileName);
-  hb.FirstFileName = FirstFileName;
-  CProgressSync &sync = Sync;
-  sync.Set_NumFilesCur(hb.NumFiles);
+    AddHashBundleRes(PropNameValPairs, hb);
+    hb.FirstFileName = FirstFileName;
+    CProgressSync &sync = Sync;
+    sync.Set_NumFilesCur(hb.NumFiles);
 
-  // CProgressMessageBoxPair &pair = GetMessagePair(hb.NumErrors != 0);
-  // pair.Message = s;
-  // LangString(IDS_CHECKSUM_INFORMATION, pair.Title);
+    // CProgressMessageBoxPair &pair = GetMessagePair(hb.NumErrors != 0);
+    // pair.Message = s;
+    // LangString(IDS_CHECKSUM_INFORMATION, pair.Title);
 
-  return S_OK;
+    return S_OK;
 }
 
-
 HRESULT CHashCallbackGUI::ProcessVirt()
 {
-  NumFiles = 0;
-  AString errorInfo;
-  HRESULT res = HashCalc(EXTERNAL_CODECS_LOC_VARS
-      *censor, *options, errorInfo, this);
-  return res;
+    NumFiles = 0;
+    AString errorInfo;
+    HRESULT res = HashCalc(EXTERNAL_CODECS_LOC_VARS * censor, *options, errorInfo, this);
+    return res;
 }
 
-
 HRESULT HashCalcGUI(
-    DECL_EXTERNAL_CODECS_LOC_VARS
-    const NWildcard::CCensor &censor,
+    DECL_EXTERNAL_CODECS_LOC_VARS const NWildcard::CCensor &censor,
     const CHashOptions &options,
     bool &messageWasDisplayed)
 {
-  CHashCallbackGUI t;
-  #ifdef EXTERNAL_CODECS
-  t.__externalCodecs = __externalCodecs;
-  #endif
-  t.censor = &censor;
-  t.options = &options;
+    CHashCallbackGUI t;
+#ifdef EXTERNAL_CODECS
+    t.__externalCodecs = __externalCodecs;
+#endif
+    t.censor = &censor;
+    t.options = &options;
 
-  t.ShowCompressionInfo = false;
+    t.ShowCompressionInfo = false;
 
-  const UString title = LangString(IDS_CHECKSUM_CALCULATING);
+    const UString title = LangString(IDS_CHECKSUM_CALCULATING);
 
-  t.MainTitle = "7-Zip"; // LangString(IDS_APP_TITLE);
-  t.MainAddTitle = title;
-  t.MainAddTitle.Add_Space();
+    t.MainTitle = "7-Zip"; // LangString(IDS_APP_TITLE);
+    t.MainAddTitle = title;
+    t.MainAddTitle.Add_Space();
 
-  RINOK(t.Create(title));
-  messageWasDisplayed = t.ThreadFinishedOK && t.MessagesDisplayed;
-  return S_OK;
+    RINOK(t.Create(title));
+    messageWasDisplayed = t.ThreadFinishedOK && t.MessagesDisplayed;
+    return S_OK;
 }
 
-
 void ShowHashResults(const CPropNameValPairs &propPairs, HWND hwnd)
 {
-  CListViewDialog lv;
-  
-  FOR_VECTOR (i, propPairs)
-  {
-    const CProperty &pair = propPairs[i];
-    lv.Strings.Add(pair.Name);
-    lv.Values.Add(pair.Value);
-  }
-  
-  lv.Title = LangString(IDS_CHECKSUM_INFORMATION);
-  lv.DeleteIsAllowed = true;
-  lv.SelectFirst = false;
-  lv.NumColumns = 2;
-  
-  lv.Create(hwnd);
-}
+    CListViewDialog lv;
 
+    FOR_VECTOR(i, propPairs)
+    {
+        const CProperty &pair = propPairs[i];
+        lv.Strings.Add(pair.Name);
+        lv.Values.Add(pair.Value);
+    }
+
+    lv.Title = LangString(IDS_CHECKSUM_INFORMATION);
+    lv.DeleteIsAllowed = true;
+    lv.SelectFirst = false;
+    lv.NumColumns = 2;
+
+    lv.Create(hwnd);
+}
 
 void ShowHashResults(const CHashBundle &hb, HWND hwnd)
 {
-  CPropNameValPairs propPairs;
-  AddHashBundleRes(propPairs, hb);
-  ShowHashResults(propPairs, hwnd);
+    CPropNameValPairs propPairs;
+    AddHashBundleRes(propPairs, hb);
+    ShowHashResults(propPairs, hwnd);
 }
 
-
 void CHashCallbackGUI::ProcessWasFinished_GuiVirt()
 {
-  ShowHashResults(PropNameValPairs, *this);
+    ShowHashResults(PropNameValPairs, *this);
 }