xevion/Pac-Man
1
0
Fork 0
mirror of https://github.com/Xevion/Pac-Man.git synced 2025-12-11 00:07:57 -06:00
Code Issues Packages Projects Releases Wiki Activity

fix: profiling system calculates mean of sums, not mean of means

Browse Source
This commit is contained in:
Ryan Walters
2025-09-01 12:00:01 -05:00
parent 98196f3e07
commit bed913d016
2 changed files with 21 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/systems/debug.rs
View File

@@ -54,8 +54,8 @@ fn render_timing_display(
.unwrap_or(0); .unwrap_or(0);
// Only draw background if there is text to display // Only draw background if there is text to display
if max_width > 0 { let total_height = (lines.len() as u32) * line_height as u32;
let total_height = (lines.len() as u32) * line_height as u32; if max_width > 0 && total_height > 0 {
let bg_padding = 5; let bg_padding = 5;
// Draw background // Draw background

40
src/systems/profiling.rs
View File

@@ -111,28 +111,26 @@ impl SystemTimings {
} }
pub fn get_total_stats(&self) -> (Duration, Duration) { pub fn get_total_stats(&self) -> (Duration, Duration) {
let timings = self.timings.read(); let duration_sums = {
let mut all_durations = Vec::new(); let timings = self.timings.read();
timings
.iter()
.map(|(_, queue)| queue.lock().iter().sum::<Duration>())
.collect::<Vec<_>>()
};
for queue in timings.values() { let mean = duration_sums.iter().sum::<Duration>() / duration_sums.len() as u32;
all_durations.extend(queue.lock().iter().map(|d| d.as_secs_f64() * 1000.0)); let variance = duration_sums
} .iter()
.map(|x| {
let diff_secs = x.as_secs_f64() - mean.as_secs_f64();
diff_secs * diff_secs
})
.sum::<f64>()
/ duration_sums.len() as f64;
let std_dev_secs = variance.sqrt();
if all_durations.is_empty() { (mean, Duration::from_secs_f64(std_dev_secs))
return (Duration::ZERO, Duration::ZERO);
}
let count = all_durations.len() as f64;
let sum: f64 = all_durations.iter().sum();
let mean = sum / count;
let variance = all_durations.iter().map(|x| (x - mean).powi(2)).sum::<f64>() / count;
let std_dev = variance.sqrt();
(
Duration::from_secs_f64(mean / 1000.0),
Duration::from_secs_f64(std_dev / 1000.0),
)
} }
pub fn format_timing_display(&self) -> SmallVec<[String; SystemId::COUNT]> { pub fn format_timing_display(&self) -> SmallVec<[String; SystemId::COUNT]> {
@@ -153,7 +151,7 @@ impl SystemTimings {
sorted_stats.sort_by(|a, b| b.1 .0.cmp(&a.1 .0)); sorted_stats.sort_by(|a, b| b.1 .0.cmp(&a.1 .0));
// Add the top 5 most expensive systems // Add the top 5 most expensive systems
for (name, (avg, std_dev)) in sorted_stats.iter().take(5) { for (name, (avg, std_dev)) in sorted_stats.iter().take(7) {
timing_data.push((name.to_string(), *avg, *std_dev)); timing_data.push((name.to_string(), *avg, *std_dev));
} }