feat: improve test reliability and add request tracing

- Add retry configuration for flaky tests (2 retries for default, 3 for
OAuth)
- Configure test groups with proper concurrency limits (serial: 1,
integration: 4)
- Add tower-http tracing layer with custom span formatting for HTTP
requests
- Simplify database pool handling by removing unnecessary Arc wrapper
- Improve test context setup with better logging and error handling
- Refactor user creation parameters for better clarity and consistency
- Add debug logging for OAuth cookie handling

pacman-server/src/app.rs

@@ -6,6 +6,7 @@ use std::sync::Arc;
 use std::time::Duration;
 use tokio::sync::{Notify, RwLock};
 use tokio::task::JoinHandle;
+use tracing::info_span;
 
 use crate::data::pool::PgPool;
 use crate::{auth::AuthRegistry, config::Config, image::ImageStorage, routes};
@@ -36,7 +37,7 @@ pub struct AppState {
     pub sessions: Arc<DashMap<String, crate::auth::provider::AuthUser>>,
     pub jwt_encoding_key: Arc<EncodingKey>,
     pub jwt_decoding_key: Arc<DecodingKey>,
-    pub db: Arc<PgPool>,
+    pub db: PgPool,
     pub health: Arc<RwLock<Health>>,
     pub image_storage: Arc<ImageStorage>,
     pub healthchecker_task: Arc<RwLock<Option<JoinHandle<()>>>>,
@@ -71,7 +72,7 @@ impl AppState {
             sessions: Arc::new(DashMap::new()),
             jwt_encoding_key: Arc::new(EncodingKey::from_secret(jwt_secret.as_bytes())),
             jwt_decoding_key: Arc::new(DecodingKey::from_secret(jwt_secret.as_bytes())),
-            db: Arc::new(db),
+            db: db,
             health: Arc::new(RwLock::new(Health::default())),
             image_storage,
             healthchecker_task: Arc::new(RwLock::new(None)),
@@ -100,7 +101,7 @@ impl AppState {
                     }
 
                     // Run the actual health check
-                    let ok = sqlx::query("SELECT 1").execute(&*db_pool).await.is_ok();
+                    let ok = sqlx::query("SELECT 1").execute(&db_pool).await.is_ok();
                     {
                         let mut h = health_state.write().await;
                         h.set_database(ok);
@@ -127,13 +128,35 @@ impl AppState {
 
     /// Force an immediate health check (debug mode only)
     pub async fn check_health(&self) -> bool {
-        let ok = sqlx::query("SELECT 1").execute(&*self.db).await.is_ok();
+        let ok = sqlx::query("SELECT 1").execute(&self.db).await.is_ok();
         let mut h = self.health.write().await;
         h.set_database(ok);
         ok
     }
 }
 
+/// Create a custom span for HTTP requests with reduced verbosity
+pub fn make_span<B>(request: &axum::http::Request<B>) -> tracing::Span {
+    let path = request
+        .uri()
+        .path_and_query()
+        .map(|v| v.as_str())
+        .unwrap_or_else(|| request.uri().path());
+
+    if request.method() == axum::http::Method::GET {
+        info_span!(
+            "request",
+            path = %path,
+        )
+    } else {
+        info_span!(
+            "request",
+            method = %request.method(),
+            path = %path,
+        )
+    }
+}
+
 /// Create the application router with all routes and middleware
 pub fn create_router(app_state: AppState) -> Router {
     Router::new()
@@ -147,6 +170,13 @@ pub fn create_router(app_state: AppState) -> Router {
         .with_state(app_state)
         .layer(CookieLayer::default())
         .layer(axum::middleware::from_fn(inject_server_header))
+        .layer(
+            tower_http::trace::TraceLayer::new_for_http()
+                .make_span_with(make_span)
+                .on_request(|_request: &axum::http::Request<axum::body::Body>, _span: &tracing::Span| {
+                    // Disable request logging by doing nothing
+                }),
+        )
 }
 
 /// Inject the server header into responses